Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
target_frameworks
private_deps
attribute to _binary/_library rules that is intended for compile time dependencies. These dependencies are not transitively passed and do not become part of the runfiles.Why?
The transition is needed because before the change we were just taking the default tfm and passing it to the build actions. This did not make sense since you could update rules_dotnet and then the default tfm would be 6.0 but your targets would still target 5.0. There was also an issue that if you were e.g. targeting
netstandard2.1
we would still pass the default tfm to the build actions.The
private_deps
attribute is needed so that we can pass in targeting packs without passing them transitively to parents. Targeting packs should not be passed transitively because that causes conflicts between targeting packs.Fixes #297