Disable prerelease feature for nuget2bazel (#250)

bazel-contrib · May 18, 2021 · 64ad748 · 64ad748
1 parent 2c9f9c8
commit 64ad748
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 17 deletions.
diff --git a/tests/tools/nuget2bazel/MicrosoftConfigurationT.cs b/tests/tools/nuget2bazel/MicrosoftConfigurationT.cs
@@ -0,0 +1,21 @@
+using System.Linq;
+using System.Threading.Tasks;
+using nuget2bazel;
+using Xunit;
+
+namespace nuget2bazel_test
+{
+    public class MicrosoftConfigurationT : TestBase
+    {
+        // If we allow prerelease versions then this test fails for 5.9.0, 5.9.1 and 5.10.0-preview.
+        // It seems that there is an internal error in Nuget.Resolver related to sorting versions.
+        [Fact]
+        public async Task MicrosoftConfigurationTest()
+        {
+            var project = new TestProject(_prjConfig);
+            var addCmd = new AddCommand();
+
+            await addCmd.DoWithProject("https://api.nuget.org/v3/index.json", "Microsoft.Extensions.Configuration", "5.0.0", project, false);
+        }
+    }
+}
diff --git a/tests/tools/nuget2bazel/nuget2bazel-test.csproj b/tests/tools/nuget2bazel/nuget2bazel-test.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net5.0</TargetFramework>
     <RootNamespace>nuget2bazel_test</RootNamespace>
 
     <IsPackable>false</IsPackable>

diff --git a/tools/nuget2bazel/AddCommand.cs b/tools/nuget2bazel/AddCommand.cs
@@ -57,7 +57,7 @@ public async Task DoWithProject(string nugetSource, string package, string versi
                 PackagesFolderNuGetProject = project
             };
 
-            const bool allowPrereleaseVersions = true;
+            const bool allowPrereleaseVersions = false;
             const bool allowUnlisted = false;
             var resolutionContext = new ResolutionContext(
                 lowest ? DependencyBehavior.Lowest : DependencyBehavior.HighestMinor, allowPrereleaseVersions, allowUnlisted, VersionConstraints.None);

diff --git a/tools/nuget2bazel/UpdateCommand.cs b/tools/nuget2bazel/UpdateCommand.cs
@@ -45,7 +45,7 @@ public async Task DoWithProject(string nugetSource, string package, string versi
                 PackagesFolderNuGetProject = project
             };
 
-            const bool allowPrereleaseVersions = true;
+            const bool allowPrereleaseVersions = false;
             const bool allowUnlisted = false;
             var resolutionContext = new ResolutionContext(
                 lowest ? DependencyBehavior.Lowest : DependencyBehavior.HighestMinor, allowPrereleaseVersions, allowUnlisted, VersionConstraints.None);

diff --git a/tools/nuget2bazel/nuget2bazel.csproj b/tools/nuget2bazel/nuget2bazel.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>net5.0</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/tools/nuget2bazel/nuget2bazel.sln.DotSettings.user b/tools/nuget2bazel/nuget2bazel.sln.DotSettings.user