Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bazel_features.bzlmod to bazel_features.external_deps #4

Merged
merged 2 commits into from
May 3, 2023

Conversation

Wyverald
Copy link
Collaborator

@Wyverald Wyverald commented May 2, 2023

Continuing the trend of de-emphasizing the name "Bzlmod". I think it would make more sense to group features related to external dependencies together, instead of just Bzlmod features. Not sure whether this should be called external or external_deps or just repos, so I just went with the shortest one.

Continuing the trend of de-emphasizing the name "Bzlmod". I think it would make more sense to group features related to external dependencies together, instead of just Bzlmod features. Not sure whether this should be called `external` or `external_deps` or just `repos`, so I just went with the shortest one.
@meteorcloudy
Copy link
Collaborator

I slightly prefer external_deps a bit since it's more intuitive.

@meteorcloudy
Copy link
Collaborator

@alexeagle Can you add @fmeum as a collaborator on this repo? It seems I cannot assign him as reviewer.

@meteorcloudy meteorcloudy self-requested a review May 2, 2023 15:48
@fmeum
Copy link
Member

fmeum commented May 2, 2023

I am in the rules_authors team now, but don't seem to have permissions for this particular repo.

@Wyverald
Copy link
Collaborator Author

Wyverald commented May 2, 2023

@fmeum would you prefer external_deps as well? I'm personally undecided so will go with the majority vote.

@fmeum
Copy link
Member

fmeum commented May 2, 2023

I also prefer external_dep as module extensions naturally fall under it, but aren't repositories.

@alexeagle
Copy link
Contributor

@fmeum what access would you like that you don't get as a rules-authors team member?

@fmeum
Copy link
Member

fmeum commented May 3, 2023

@fmeum what access would you like that you don't get as a rules-authors team member?

Given that we probably want to protect the main branch with required reviews, could you give me write permissions so that I can approve PRs?

@Wyverald Wyverald changed the title Rename bazel_features.bzlmod to bazel_features.repos Rename bazel_features.bzlmod to bazel_features.external_deps May 3, 2023
@Wyverald Wyverald merged commit b653660 into main May 3, 2023
@Wyverald Wyverald deleted the rename-bzlmod branch May 3, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants