-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename bazel_features.bzlmod
to bazel_features.external_deps
#4
Conversation
Continuing the trend of de-emphasizing the name "Bzlmod". I think it would make more sense to group features related to external dependencies together, instead of just Bzlmod features. Not sure whether this should be called `external` or `external_deps` or just `repos`, so I just went with the shortest one.
I slightly prefer |
@alexeagle Can you add @fmeum as a collaborator on this repo? It seems I cannot assign him as reviewer. |
I am in the rules_authors team now, but don't seem to have permissions for this particular repo. |
@fmeum would you prefer |
I also prefer |
@fmeum what access would you like that you don't get as a rules-authors team member? |
Given that we probably want to protect the main branch with required reviews, could you give me write permissions so that I can approve PRs? |
bazel_features.bzlmod
to bazel_features.repos
bazel_features.bzlmod
to bazel_features.external_deps
Continuing the trend of de-emphasizing the name "Bzlmod". I think it would make more sense to group features related to external dependencies together, instead of just Bzlmod features. Not sure whether this should be called
external
orexternal_deps
or justrepos
, so I just went with the shortest one.