Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bazel_features.bzlmod.is_enabled #2

Merged
merged 1 commit into from
May 2, 2023

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Apr 27, 2023

No description provided.

@fmeum
Copy link
Member Author

fmeum commented Apr 27, 2023

This is mostly me exploring the design space of this repo - this could be a useful addition if we think it's the right place for it.

@meteorcloudy meteorcloudy requested a review from Wyverald April 28, 2023 11:08
@Wyverald
Copy link
Collaborator

I'm a bit undecided. Not entirely sure we want this sort of "flag detection" stuff. Any pros and cons in mind?

@brentleyjones
Copy link
Collaborator

Pros:

  • People ask for this a lot
  • There isn't a global attribute to look at to see if it's enabled
  • That's what this features repo is about, right?

Cons:

  • I can't really think of any? If people need this (and there are numerous examples of the need), why not add it?

@Wyverald
Copy link
Collaborator

Wyverald commented May 2, 2023

I'm sufficiently convinced -- tried thinking of substantial cons, couldn't think of any.

@Wyverald Wyverald merged commit c8ee632 into bazel-contrib:main May 2, 2023
@fmeum fmeum deleted the bzlmod-is-enabled branch May 2, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants