Adapt mypy bazel rule to work with Bazel 8 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this script invokes mypy at the `external/{REPO_NAME}/mypy/mypy` path.
This was previously valid, but from Bazel 8 onwards it's not valid, and the external
repo can no longer be found at that path. The correct path is now
`../{REPO_NAME}/mypy/mypy`.
More details at
bazelbuild/bazel#23574
This change adapts the path to mypy.
Also pin the version in the `examples` dir to prevent it from getting broken by new incompatible upstream versions.
alexander-scott
force-pushed
the
patch-1
branch
from
01d516e to
2315df6
Compare
alexander-scott
changed the title
--nolegacy_external_runfiles
alexander-scott
changed the title
alexander-scott
changed the title
|
Hi @alexeagle @adzenith, if you have a minute, a review would be welcome on this change :) It should help an internal repo of mine which heavily uses the bazel-mypy-integration ruleset to migrate to Bazel 8 |
alexeagle
reviewed
Feb 17, 2025
| @@ -27,7 +22,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - uses: p0deje/setup-bazel@0.9.0 | |||
| with: | |||
| bazelrc: common --announce_rc --color=yes --enable_bzlmod=${{ matrix.bzlmodEnabled }} | |||
There was a problem hiding this comment.
I imagine we can do some cleanup in the root module if it's no longer built with WORKSPACE, I'll take that as a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
--legacy_external_runfilesto false bazelbuild/bazel#23574 in Bazel 8. As detailed in the linked issue description,$RUNFILES/<main repo>/external/<external repo>/<path>is removed in favour of$RUNFILES/<external repo>/<path>. To get to the new external location from the<main repo>path, we just need to go up one directory and the rest of the path remains correct. It might seem a bit hacky, but I am not aware of an API making it easier to get to this new location. This wiki page also illustrates the tree change quite well https://github.com/bazelbuild/bazel/wiki/Updating-the-runfiles-tree-structure:my-program.runfiles/ my_workspace_name/ my-program - external/ - mypy_integration/ - mypy/ - mypy mypy_integration/ mypy/ mypy