fix: add runfiles _repo_mapping to tar archive #932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to keep this as compact as possible |
cerisier
reviewed
Sep 13, 2024
cerisier
reviewed
Sep 13, 2024
steeve
force-pushed
the
steeve/runfiles_manifest
branch
2 times, most recently
from
0f5e449 to
c093f08
Compare
When using bzlmod, runfiles lookup will fail without it.
steeve
force-pushed
the
steeve/runfiles_manifest
branch
from
c093f08 to
5dbe6a2
Compare
steeve
changed the title
thesayyn
approved these changes
Sep 26, 2024
|
@steeve could you rebase? |
|
Closing in favor of #953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thank you for this great library!
This PR adds
_repo_mappingto runfiles directory to enable proper runfiles lookup when bzlmod is enabled. Without it, lookup will fail.