Support MODULE.bazel test cases for gazelle_generation_test. #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazelle_generation_test uses the existence of a WORKSPACE file to indicate a directory is a test case. This PR extends gazelle_generation_test to also look for directories with a MODULE.bazel file. A test case is modified to check the logic.
gonzojive
force-pushed
the
bzlmod-generation-tests
branch
from
02ffbf2 to
1d2154f
Compare
fmeum
approved these changes
Oct 6, 2024
fmeum
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature (testing enhancement for extension developers)
What package or component does this PR mostly affect?
gazelle_generation_test
What does this PR do? Why is it needed?
gazelle_generation_test uses the existence of a WORKSPACE file to indicate a directory is a test case. This PR extends gazelle_generation_test to also look for directories with a MODULE.bazel file.
A test case is modified to check the logic.
Which issues(s) does this PR fix?
Fixes # 1947
Other notes for review
Added as part of kotlin gazelle development.