Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOBT-689 (Pt2): Spot forecast subsetting using a neighbour cube #7

Closed
wants to merge 8 commits into from
Closed

MOBT-689 (Pt2): Spot forecast subsetting using a neighbour cube #7

wants to merge 8 commits into from

Commits on May 28, 2024

  1. MOBT-689 (Pt 1): Move functionality out of the spot-extract CLI into … 

    …a plugin (metoppv#1996)

* Move neighbour_finding_method_name function out of the NeighbourSelection plugin into a new spot data utilities file. This is reused in the spot-extraction CLI, soon to be in the plugin, and should be made more common.

* Move check_grid_match into metadata utilities along with the hash generation code which is more logical. This removes imports from the spot_extract file for other plugins that use this functionality.

* Move all functionality from the spot-extract CLI to a wrapper class that can be invoked by the CLI. Still needs doc-strings, tidying up, any potential rationalisation, and unit tests for the new class.

* Add unit tests for the SpotManipulation plugin which has taken on logic and calling of other plugins that was previously done in the CLI layer.

* Fix up dz_rescaling code and apply_height_adjustment CLI which use the neighbour_finding_method_name method which was previously part of the NeighbourFinding plugin but which is now a standalone utility. Update the plugin which the spot_extraction CLI calls.

* Resolves doc-string error highlighted by sphinx.

* Change test paramerisation to help with testing spot forecast subsetting in subsequent PR.

* Additional tests for realization collapse and for percentile extraction directly from realization data. Modifies the test in spot_manipulation for selecting the percentile method to check if data is actually masked, rather than just of masked type. This will enable the fast method to be used in more cases.

* Rename neighbour_finding_method_name to get_neighbour_finding_method_name.

* Review changes.
    @bayliffe
    bayliffe committed May 28, 2024
    Configuration menu
    Copy the full SHA
    dee4f9b View commit details
    Browse the repository at this point in the history

  2. Add basic functionality to allow subsetting a spot-forecast cube usin… 

    …g a neighbour cube via the spot-extraction CLI / SpotManipulation plugin.
    @bayliffe
    bayliffe committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2d5d0bf View commit details
    Browse the repository at this point in the history

  3. Add comment

    @bayliffe
    bayliffe committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1ca7b59 View commit details
    Browse the repository at this point in the history

  4. Add unit tests for spot forecast subsetting using the SpotManipulatio… 

    …n plugin.
    @bayliffe
    bayliffe committed May 28, 2024
    Configuration menu
    Copy the full SHA
    046ea8a View commit details
    Browse the repository at this point in the history

  5. Additional tests for spot subsetting.

    @bayliffe
    bayliffe committed May 28, 2024
    Configuration menu
    Copy the full SHA
    7667aa5 View commit details
    Browse the repository at this point in the history

  6. Add handling of None IDs and an associated test.

    @bayliffe
    bayliffe committed May 28, 2024
    Configuration menu
    Copy the full SHA
    7027b4e View commit details
    Browse the repository at this point in the history

  7. Add handling for case where no spot forecasts remain after the subset… 

    …ting.
    @bayliffe
    bayliffe committed May 28, 2024
    Configuration menu
    Copy the full SHA
    25db6c0 View commit details
    Browse the repository at this point in the history

  8. Add an acceptance test that demonstrated subsetting an existing spot … 

    …forecast to the sites defined in a neighbour cube with valid IDs.
    @bayliffe
    bayliffe committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f6722df View commit details
    Browse the repository at this point in the history