Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrectly modified ScreenLogger #512

Merged
merged 4 commits into from
Sep 7, 2024

Conversation

phi-friday
Copy link
Contributor

Before I applied #497 it worked like this

cells.append(self._format_number(res["params"][key]))

but after,

cells[3] = self._format_number(res["params"][key])

I expect it to work the same as before.

@phi-friday phi-friday changed the title fix: Unexpectedly modified ScreenLogger fix: Incorrectly modified ScreenLogger Jul 29, 2024
Copy link
Member

@till-m till-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good fix. I was just wondering about this.

Will merge after the docs change.

@till-m till-m merged commit aed6a25 into bayesian-optimization:master Sep 7, 2024
10 checks passed
@till-m
Copy link
Member

till-m commented Sep 7, 2024

Thanks!

@phi-friday phi-friday deleted the fix-params-log branch September 8, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants