Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replace list with deque #508

Merged

Conversation

phi-friday
Copy link
Contributor

Replace queue implemented using list with deque.

The implementation with list appears to be due to the use of append() and #370 .
If append() is used, deque is more efficient, and #370 is also solved.

@phi-friday phi-friday force-pushed the fix-replace-list-with-deque branch from 3f79fd4 to 23f4147 Compare September 8, 2024 08:47
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (aed6a25) to head (23f4147).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
- Coverage   96.19%   96.12%   -0.08%     
==========================================
  Files          10       10              
  Lines         867      851      -16     
==========================================
- Hits          834      818      -16     
  Misses         33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@till-m till-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good thing to use a built-in for this instead of writing it ourselves!

@till-m till-m merged commit 2298f7c into bayesian-optimization:master Sep 8, 2024
12 of 13 checks passed
@phi-friday phi-friday deleted the fix-replace-list-with-deque branch September 8, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants