-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry packaging #458
Poetry packaging #458
Conversation
add install poetry step to CI
…ayesianOptimization into poetry_packaging
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
==========================================
- Coverage 98.70% 94.91% -3.79%
==========================================
Files 8 9 +1
Lines 540 669 +129
Branches 90 0 -90
==========================================
+ Hits 533 635 +102
- Misses 3 34 +31
+ Partials 4 0 -4 ☔ View full report in Codecov by Sentry. |
Update: also had to remove python3.8 from supported packages. Poetry is quite strict about compatibility, and there is no version of numpy which supports both 3.8 and 3.12. 3.8 is end of life in October this year, so I think this is ok.... (noting that previous PyPi packages will still be available and support older python versions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (haven't had a look at the notebook changes though). I like that this cleans up some old, presumably unused files.
I would also ask you to wait with merging this until I'm done with the docstrings, if that's okay.
At the risk of asking a potentially stupid question -- is it possible to host docs for multiple releases in parallel such that one can view the docs of a specific version instead of always viewing the most current one? |
Hey @till-m
|
…ayesianOptimization into poetry_packaging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't catch anything else. LGTM! :)
In this PR, I have recast the packaging mechanism to user poetry. This brings us line with latest python recommendations around packaging using a
pyproject.toml
file. Note thatsetup.py
which we were using is considered deprecated. I have also made a few other changes:This PR paves the way for another change I would like to make: add a CI job for 'release' as described in #426. This would mean that when we release a package through GH releases, a version will also be automatically uploaded to PyPi.