Fix warmup phase not considering constraints

[leandrobbraga]

Fixes #412

Previously the warmup phase would use the acquisition function directly without considering the p_constraint. This could lead to inflated values of the acquisition function in unfeasible spaces.

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (d4ed3a6) 98.57% compared to head (bdfa55b) 98.56%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
- Coverage   98.57%   98.56%   -0.01%     
==========================================
  Files           8        8              
  Lines         560      559       -1     
  Branches       79       79              
==========================================
- Hits          552      551       -1     
  Misses          4        4              
  Partials        4        4              

Impacted Files	Coverage Δ
bayes_opt/target_space.py	99.18% <ø> (-0.01%)	⬇️
bayes_opt/util.py	97.84% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[till-m]

Hey @leandrobbraga, sorry for the delay. I should be able to review both PR's later today.

[till-m]

PR looks good to me! Will also merge tomorrow, provided merging #415 doesn't cause any conflicts!

[till-m]

Thanks @leandrobbraga, both for spotting the problems in the first place and for the excellent contributions you've made!