Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecated iOS functions, lint fixes #183

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Resolve deprecated iOS functions, lint fixes #183

merged 1 commit into from
Aug 13, 2021

Conversation

alexookah
Copy link

@alexookah alexookah commented Aug 12, 2021

In this MR, I resolved all deprecated functions for Capacitor 3.0 in iOS.
Also fixed some minor lint fixes (removing ;)
Hope someone else will handle also the android changes

@alexookah
Copy link
Author

alexookah commented Aug 13, 2021

I am not really sure for the change:
call.save() if it should really be changed to call.keepAlive = yes.
Maybe this https://capacitorjs.com/docs/core-apis/saving-calls helps verify my change?

@baumblatt baumblatt merged commit ec6d4d0 into baumblatt:next Aug 13, 2021
@baumblatt
Copy link
Owner

Hi @alexookah ,

First of all, great work here, congrats.

The version 3.1.2-rc.0 with your changes is out there under tag next.

Everything works fine here, looking forward to hearing of your tests.

I will take a look at android platform as soon as possible.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants