Fixes for Windows

[davedoesdev]

Tests now pass and it compiles on Windows!

Question:

• Is utime still needed given fs.utimes exists?

[codecov-io]

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files           1        1           
  Lines          83       83           
  Branches       24       24           
=======================================
  Hits           70       70           
  Misses         13       13

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808593c...f2b5e9f. Read the comment docs.

[davedoesdev]

Appveyor doesn't seem to be picking up change to run on Node 8
EDIT: fixed

[davedoesdev]

Travis and Appveyor both building successfully.

[davedoesdev]

Works on Node 8.1.3. Might work on earlier versions, not sure when libuv/libuv#1323 went into Node.

[baudehlo]

It's high time we removed support for this.

[baudehlo]

And by "this" I mean anything less than node v6 on travis.

[baudehlo]

Can you please bump this to >= v6. It's a shame we can't do platform specific versions given Windows now requires v8. I searched and the only solution is a failing install script.

[davedoesdev]

@baudehlo sure see latest commit

[davedoesdev]

@baudehlo is there anything else you need on this PR?

[baudehlo]

I don't think so. Just need some free time (baby, new house, etc).

…

On Jul 19, 2017, at 6:46 PM, David Halls ***@***.***> wrote: @baudehlo is there anything else you need on this PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[davedoesdev]

@baudehlo been there - take time for what's important.

[baudehlo]

Merged

[baudehlo]

BTW after merge Travis fails. Not sure why.

…

On Thu, Jul 20, 2017 at 1:40 AM, David Halls ***@***.***> wrote: @baudehlo <https://github.com/baudehlo> been there - take time for what's important. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAobY7u3RPnzhcNlT4d1MrvrEyxTMz21ks5sPuhHgaJpZM4ORcVU> .

[davedoesdev]

Node 8 behaviour has changed for the -1 utime test. It sets it fine (and Node 6 and Python read the atime as -1). But for Node 8 atime in that case is NaN.

[davedoesdev]

@baudehlo how do utime and utimeSync provided by fs-ext differ from fs.futimes and fs.futimesSync in Node core?

[baudehlo]

I think those were just added after I released this.

…

On Jul 20, 2017, at 6:18 PM, David Halls ***@***.***> wrote: @baudehlo how do utime and utimeSync provided by fs-ext differ from fs.futimes and fs.futimesSync don't? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[davedoesdev]

How would you feel about removing them or making them aliases?

…

On 20 Jul 2017 11:52 p.m., "Matt Sergeant" ***@***.***> wrote: I think those were just added after I released this. > On Jul 20, 2017, at 6:18 PM, David Halls ***@***.***> wrote: > > @baudehlo how do utime and utimeSync provided by fs-ext differ from fs.futimes and fs.futimesSync don't? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACOMU8bjBcJ_GS_8R1A8NCVss3-rd0srks5sP9oZgaJpZM4ORcVU> .

[baudehlo]

Sounds good to me.

…

On Jul 20, 2017, at 7:00 PM, David Halls ***@***.***> wrote: How would you feel about removing them or making them aliases? On 20 Jul 2017 11:52 p.m., "Matt Sergeant" ***@***.***> wrote: > I think those were just added after I released this. > > > On Jul 20, 2017, at 6:18 PM, David Halls ***@***.***> > wrote: > > > > @baudehlo how do utime and utimeSync provided by fs-ext differ from > fs.futimes and fs.futimesSync don't? > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub, or mute the thread. > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#70 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACOMU8bjBcJ_GS_8R1A8NCVss3-rd0srks5sP9oZgaJpZM4ORcVU> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[davedoesdev]

#71