Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Grafana dashboards work, when Tesla API did not return a display_name #1399

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Make Grafana dashboards work, when Tesla API did not return a display_name #1399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions TeslaLogger/WebHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,6 +1939,13 @@ public string GetVehicles()
System.Diagnostics.Debug.WriteLine(DateTime.Now.ToString() + " : " + OnlineState);

string display_name = r2["display_name"].ToString();
if(string.IsNullOrEmpty(display_name) && string.IsNullOrEmpty(car.DisplayName))
{
// Grafana dashboards break, if Car's display_name is null or empty, so
// if display_name is null from API and car.DisplayName is also null already
// we just write "Car $id" to database because that is how the fallback in admin panel works
display_name = $"Car {car.CarInDB}";
}
if (!string.IsNullOrEmpty(display_name) && car.DisplayName != display_name)
{
car.DisplayName = display_name;
Expand Down
Loading