Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add Cary Flag check to RDRAND #247

Merged
merged 1 commit into from
Jul 13, 2020
Merged

ENH: Add Cary Flag check to RDRAND #247

merged 1 commit into from
Jul 13, 2020

Conversation

bashtage
Copy link
Owner

Add check of carry flag and raise RuntimeError if not successful
Add retry variable

closes #246

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #247 into master will decrease coverage by 0.01%.
The diff coverage is 92.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   95.20%   95.18%   -0.02%     
==========================================
  Files          57       57              
  Lines       13051    13187     +136     
  Branches      235      235              
==========================================
+ Hits        12425    12552     +127     
- Misses        605      614       +9     
  Partials       21       21              
Impacted Files Coverage Δ
randomgen/_testing.py 100.00% <ø> (ø)
randomgen/common.pyx 80.94% <ø> (ø)
randomgen/entropy.pyx 84.61% <ø> (ø)
randomgen/seed_sequence.py 100.00% <ø> (ø)
randomgen/tests/test_stability.py 97.95% <0.00%> (ø)
randomgen/rdrand.pyx 87.80% <89.24%> (+4.02%) ⬆️
randomgen/tests/test_direct.py 99.72% <100.00%> (+<0.01%) ⬆️
randomgen/tests/test_generator_117.py 100.00% <100.00%> (ø)
randomgen/tests/test_lcg128mix_pcg64dxsm.py 96.83% <100.00%> (ø)
randomgen/tests/test_randomstate_regression.py 99.06% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3100f...638aa64. Read the comment docs.

@bashtage bashtage force-pushed the refactor-rdrand branch 8 times, most recently from db58d7f to bf8d8e8 Compare July 13, 2020 12:22
Add check of carry flag and raise RuntimeError if not successful
Add retry variable

closes #246
@bashtage bashtage merged commit 8c24046 into master Jul 13, 2020
@bashtage bashtage deleted the refactor-rdrand branch July 13, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDRAND implementation does not appear to check CF as required in Intel software implementation guide
1 participant