Bugfix/im/handle get ring timeouts #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-mi
force-pushed
the
bugfix/im/handle-get-ring-timeouts
branch
from
3eff012
to
d11d106
Compare
| @@ -180,7 +183,7 @@ remove_non_owned_data(unknown) -> | |||
| %% The ring used to calculate the current coverage plan could not | |||
| %% be determined. In this case do nothing to prevent removing data | |||
| %% that the current coverage plan is using. | |||
| ok; | |||
| ?DEBUG("the current ring is unknown, no data can be removed", []); | |||
There was a problem hiding this comment.
You're going to still want the ok after the ?DEBUG statement.
|
@ian-mi have you branched from the most recent version of develop, https://github.com/basho/yokozuna/blob/develop/rebar.config#L17, that contains the ibrowse fix for xref? |
ian-mi
force-pushed
the
bugfix/im/handle-get-ring-timeouts
branch
from
d11d106
to
830a201
Compare
…g used. This should prevent spurious messages from being sent to the calling process in the event that the call times out.
ian-mi
force-pushed
the
bugfix/im/handle-get-ring-timeouts
branch
from
830a201
to
a2e9ce7
Compare
|
Changed the fix to use a proxy process to make the genserver call in get_ring_used rather than add an additional case to yz_events:handle_info. |
|
👍 a2e9ce7 |
borshop
added a commit
that referenced
this pull request
Mar 2, 2015
Bugfix/im/handle get ring timeouts Reviewed-by: aberghage
|
Great work @ian-mi! |
|
I was able to trigger the get_ring_used timeout by adding a five second sleep to its yz_cover:handle_call function clause, and verify that these timeouts were causing the yz_events:handle_info crashes. I then applied a2e9ce7 and verified that the crashes no longer occurred. |
|
@borshop merge |
borshop
added a commit
that referenced
this pull request
Jun 16, 2015
Bugfix/im/handle get ring timeouts Reviewed-by: aberghage (cherry picked from commit 32f8c6e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #437 (RIAK-1567) by adding a catch-all clause to yz_events:handle_info. Also adds logging to yz_events:remove_non_owned_data so that failed calls to yz_cover:get_ring_used can be detected.