Timeouts during bulk data load, possible tie in to yz_events crash and a bad state on core create [JIRA: RIAK-1585] #42
Conversation
|
This looks to be a partial implementation of #10. |
| store_schema(RD, S) -> | ||
| SchemaName = S#ctx.schema_name, | ||
| Schema = wrq:req_body(RD), | ||
| yz_schema:store(list_to_binary(SchemaName), Schema), |
There was a problem hiding this comment.
Overwriting a schema can be dangerous. I'd say at minimum by default PUT should refuse to overwrite an existing schema without a specific intent on the user's part. The schema should also be verified correct, and alert the user if invalid.
There's ample discussion of possible solutions here #10
There was a problem hiding this comment.
Really good discussion! The only goal I had for that pull request was to make it at least possible to upload a schema via http, just to be able to start get experienced with all the issues related to schemas, and there are many, as discussed separately, and as experienced by myself. So it should just be seen as an enabler to start building prototypes.
Btw I tend to agree with one of Ryan's questions/suggestions, that at some point that "raw access" to the schemas has to get replaced by some more high-level API that behind the scene based on some JSON-config puts together a consistent and correct schema and! config file, as required by Yokozuna and Solr.
There was a problem hiding this comment.
In the name of pragmatism I'd like to see this change committed (with the fixes I've mentioned) and I'll add specific issues for the points above.
|
Marcel, thanks for the contribution. Please address the two comments I made, rebase/squash into the original commit, and I'll re-test the PR. |
|
will do, thanks. |
Cleanup, plus adjustment to the changes in yz_schema
|
+1 to merge |
Added support for storing and retrieving schemas via http
Basho-JIRA
changed the title
|
We have a separate GH issue open in the backlog for bulk load performance. This seems specific to the issue fixed in RIAK-1567 (#437) and covered in https://basho.zendesk.com/agent/tickets/10352, which has seemed to work for the client. _[posted via JIRA by Zeeshan Lakhani]_ |
Basho-JIRA
added
JIRA: In Progress
JIRA: Done
JIRA: Closed
and removed
JIRA: To Do
JIRA: In Progress
labels
No description provided.