Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats formatting for riak-admin and http stats output #318

Merged
merged 3 commits into from
Feb 24, 2014

Conversation

bowrocker
Copy link
Contributor

YZ stats are not currently displayed on the riak http stats endpoint, or by riak-admin status. Add YZ stats formatting appropriate for console output with 'riak-admin status' and the htts /stats endpoint. The stats namespace for Search is transformed to /search/[query | index]/... instead of 'yokozuna'.

This PR also depends on changes to riak_kv in order to publish the stats to the 2 interfaces:

basho/riak_kv#855

Example stats output:

search_query_fail_count : 0
search_query_fail_one : 0
search_index_throughput_count : 0
search_index_throughput_one : 0
search_index_fail_count : 0
search_index_fail_one : 0
search_query_throughput_count : 0
search_query_throughput_one : 0
search_query_latency_min : 0.0
search_query_latency_max : 0.0
search_query_latency_median : 0.0
search_query_latency_percentile_95 : 0.0
search_query_latency_percentile_99 : 0.0
search_index_latency_min : 0.0
search_index_latency_max : 0.0
search_index_latency_median : 0.0
search_index_latency_percentile_95 : 0.0
search_index_latency_percentile_99 : 0.0

@rzezeski rzezeski added this to the 1.0.0 milestone Feb 24, 2014
@rzezeski
Copy link
Contributor

  • compile/unit
  • dialyzer
  • riak tests
  • code review
  • manual testing
# curl -s 'http://localhost:10018/stats' | json_pp | grep search
   "search_query_latency_max" : 0,
   "search_query_latency_min" : 0,
   "search_query_latency_95" : 0,
   "search_index_latency_median" : 0,
   "search_index_fail_count" : 0,
   "search_index_latency_99" : 0,
   "search_index_throughtput_one" : 0,
   "search_index_latency_999" : 0,
   "search_index_latency_min" : 0,
   "search_query_throughput_one" : 0,
   "search_index_latency_max" : 0,
   "search_query_latency_median" : 0,
   "search_query_latency_999" : 0,
   "search_query_throughput_count" : 0,
   "search_index_throughput_count" : 0,
   "riak_search_version" : "1.4.1-22-ga3893df",
   "search_query_latency_99" : 0,
   "search_index_latency_95" : 0,
   "search_index_fail_one" : 0,
#  ~/yz-verify/rt/riak_yz/dev/dev1/bin/riak-admin status | grep search
riak_search_version : <<"1.4.1-22-ga3893df">>
search_query_throughput_count : 0
search_query_throughput_one : 0
search_query_latency_min : 0
search_query_latency_max : 0
search_query_latency_median : 0
search_query_latency_95 : 0
search_query_latency_99 : 0
search_query_latency_999 : 0
search_index_throughput_count : 0
search_index_throughtput_one : 0
search_index_fail_count : 0
search_index_fail_one : 0
search_index_latency_min : 0
search_index_latency_max : 0
search_index_latency_median : 0
search_index_latency_95 : 0
search_index_latency_99 : 0
search_index_latency_999 : 0
Test Results:
yz_wm_extract_test-bitcask   : pass
yz_stat_test-bitcask         : pass
yz_solr_start_timeout-bitcask: pass
yz_siblings-bitcask          : pass
yz_security-bitcask          : pass
yz_schema_admin-bitcask      : pass
yz_rs_migration_test-bitcask : pass
yz_pb-bitcask                : pass
yz_monitor_solr-bitcask      : pass
yz_mapreduce-bitcask         : pass
yz_languages-bitcask         : pass
yz_index_admin-bitcask       : pass
yz_fallback-bitcask          : pass
yz_errors-bitcask            : pass
yz_dt_test-bitcask           : pass
yokozuna_essential-bitcask   : pass
aae_test-bitcask             : pass
---------------------------------------------
0 Tests Failed
17 Tests Passed
That's 100.0% for those keeping score

Everything works but we are missing the query failure stats. I say lets just get this PR in and make an issue for adding those stats.

+1 to merge.

@rzezeski
Copy link
Contributor

# ~/yz-verify/rt/riak_yz/dev/dev2/bin/riak-admin status | grep search
riak_search_version : <<"1.4.1-22-ga3893df">>
search_query_throughput_count : 0
search_query_throughput_one : 0
search_query_fail_count : 0
search_query_fail_one : 0
search_query_latency_min : 0
search_query_latency_max : 0
search_query_latency_median : 0
search_query_latency_95 : 0
search_query_latency_99 : 0
search_query_latency_999 : 0
search_index_throughput_count : 0
search_index_throughtput_one : 0
search_index_fail_count : 0
search_index_fail_one : 0
search_index_latency_min : 0
search_index_latency_max : 0
search_index_latency_median : 0
search_index_latency_95 : 0
search_index_latency_99 : 0
search_index_latency_999 : 0
# curl -s 'http://localhost:10018/stats' | json_pp | grep search
   "riak_search_version" : "1.4.1-22-ga3893df",
   "search_index_fail_one" : 0,
   "search_query_fail_count" : 0,
   "search_query_throughput_one" : 0,
   "search_index_latency_max" : 0,
   "search_index_throughput_count" : 0,
   "search_query_fail_one" : 0,
   "search_query_latency_99" : 0,
   "search_query_latency_median" : 0,
   "search_index_throughtput_one" : 0,
   "search_query_latency_95" : 0,
   "search_index_latency_min" : 0,
   "search_index_latency_99" : 0,
   "search_query_latency_max" : 0,
   "search_query_latency_min" : 0,
   "search_query_latency_999" : 0,
   "search_index_latency_999" : 0,
   "search_index_latency_median" : 0,
   "search_query_throughput_count" : 0,
   "search_index_latency_95" : 0,
   "search_index_fail_count" : 0
Test Results:
yz_stat_test-bitcask: pass
---------------------------------------------
0 Tests Failed
1 Tests Passed
That's 100.0% for those keeping score

+1 to merge.

bowrocker added a commit that referenced this pull request Feb 24, 2014
Add stats formatting for riak-admin and http stats output
@bowrocker bowrocker merged commit 7268ef2 into develop Feb 24, 2014
@bowrocker bowrocker deleted the bugfix/jra/yz_stats_2 branch February 25, 2014 11:54
@rzezeski rzezeski modified the milestones: 2.0-beta, 1.0.0 Mar 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants