Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object limit tests #398

Merged
merged 2 commits into from
Oct 17, 2013
Merged

Add object limit tests #398

merged 2 commits into from
Oct 17, 2013

Conversation

engelsanchez
Copy link
Contributor

No description provided.

@ghost ghost assigned engelsanchez Oct 2, 2013
{warn_siblings, ?WARN_SIBLINGS}]}]),
C = rt:pbc(Node1),

% Set up special logs capturing module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really related to this PR, but we really should have some sort of rt:expect_in_logs() code generalized.

@evanmcc
Copy link
Contributor

evanmcc commented Oct 16, 2013

👍

Following Evan's advice, refactoring log grepping stuff to rt.
And some minor cleanup in the object limit test:
* renaming threshold to limit for consistency
* removing line printing out log contents
@engelsanchez
Copy link
Contributor Author

I've gone ahead and refactored the log grepping into rt. It's definitely a good idea. Will merge manually.

@engelsanchez engelsanchez merged commit a77d6ec into master Oct 17, 2013
@engelsanchez engelsanchez deleted the eas-add-verify-object-limits branch October 17, 2013 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants