Confbal changes to cuttlefish schema. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seancribbs
commented
Jan 16, 2014
seancribbs
commented
- Change on/off enum to flag.
- Rename db_dir -> database_dir.
- Rename polling_interval -> refresh_frequency
- Rename repl_traps -> traps.replication
- Fixed datatypes and translations for trap thresholds.
- Extended and clarified documentation for trap thresholds.
added 2 commits
January 16, 2014 14:31
* Change on/off enum to flag. * Rename db_dir -> database_dir. * Rename polling_interval -> refresh_frequency * Rename repl_traps -> traps.replication * Fixed datatypes and translations for trap thresholds. * Extended and clarified documentation for trap thresholds.
|
It bears mentioning that we desperately wanted to make the threshold settings have better names, but the fact that they already directly correspond to SNMP MIB entries outweighed any argument in favor of changing them. We will have to live with this for a while I suppose, but only people using SNMP are affected.
|
|
+1 |
1 similar comment
|
+1 |
|
Thanks all! |
seancribbs
added a commit
that referenced
this pull request
Jan 16, 2014
Confbal changes to cuttlefish schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.