Don't crash when {error, disconnected}. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat a disconnected connection as a notfound, rather than crashing, which throws an error currently. This can be reproduced via the replication2_pg:test_pg_proxy riak_test.
ghost
assigned 
| Other -> | ||
| Other | ||
| end; | ||
| {error, disconnected} -> |
There was a problem hiding this comment.
Should this not include a clause for other {error, Reason} tuples?
There was a problem hiding this comment.
Most likely. I was only widening it to the case I had an actual failure for via r_t in an effort to be conservative.
There was a problem hiding this comment.
+1 to adding more general error handling at some point. I'm fine doing it now or punting since this specific change addresses what is broken.
There was a problem hiding this comment.
Yeah, I'd prefer to have a test for any further changes I'd make. This at least solves a known issue with pre11.
|
The replication2_pg:test_pg_proxy passes for me locally with |
cmeiklejohn
added a commit
that referenced
this pull request
Jan 21, 2014
Don't crash when {error, disconnected}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat a disconnected connection as a notfound, rather than crashing,
which throws an error currently. This can be reproduced via the
replication2_pg:test_pg_proxy riak_test.