Don't attempt to send heartbeat when invalid. #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't attempt to send the heartbeat message when it's misconfigured as a value which is not an integer, which causes the process to crash, triggering a memory leak and unbounded growth in the binary heap.
|
Resolves #579. |
|
We may want to add a validator in cuttlefish to ensure that this value is an integer or undefined. cc: @joedevivo |
|
Nice job. Changes look good, just running through some testing. Is it worth also opening a PR for this change against the |
|
I verified that the binary memory holds steady when using different sized key ranges with the 👍 |
borshop
added a commit
that referenced
this pull request
May 31, 2014
Don't attempt to send heartbeat when invalid. Reviewed-by: kellymclaughlin
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't attempt to send the heartbeat message when it's misconfigured as
a value which is not an integer, which causes the process to crash,
triggering a memory leak and unbounded growth in the binary heap.
A cmeik and andrew stone joint.
cc: @jcapricebasho @kellymclaughlin