Update strip_postcommit to remove all possible repl hooks. #589
Conversation
Previously only the currently enabled hooks were stripped. If a custom bucket property contained a hook for a disabled replication mode, then it would be resurrected whenever fixups ran.
| {<<"fun">>, <<"myhook2">>}]}). | ||
| strip_postcommit_test_() -> | ||
| [?_assertEqual( | ||
| [], % remember, returns the stipped postcommit from bprops |
There was a problem hiding this comment.
little typo here because I HAD to comment on something
|
Should this be tagged for the 2.0-RC milestone? |
|
Tagged now. I am verifying and this should be merged pretty soon. |
|
OK. |
|
I've tested this fix and its counterpart already in 1.4 branch (VP of oopsies). In both cases, you can see how even with everything disabled, removing mode_repl12 from the modes list makes the v2 postcommit hook reappear in the bucket properties, both default and in buckets with custom properties. With this fix, removing the mode_repl12 mode always ends up removing the v2 hook. When I say remove, I mean effectively removed by the fixups on local rings. The raw ring still has the hooks, of course. We do not really remove them. 👍 ⛵ 💃 |
|
👍 572517e |
…moval-2.0 Update strip_postcommit to remove all possible repl hooks. Reviewed-by: engelsanchez
|
@borshop merge |
Previously only the currently enabled hooks were stripped.
If a custom bucket property contained a hook for a disabled
replication mode, then it would be resurrected whenever fixups ran.
Accidentally pushed fix direct to 1.4 branch. If any issues with reviewing this we will have to fix there.