Finish him. #566
Merged
Finish him. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor functions so Dialyzer can more easily determine the types originating from particular callers. Resolves: riak_repl_keylist_client.erl:331: The pattern 'cancel_fullsync' can never match the type 'pause_fullsync'
Ignore invalid specs to unset_env; they are valid with tuples and execute correctly, however, moving forward we should not use it because OTP has updated the spec to reflect only the specific calls they want to support moving forward.
Provide an actual return value to prevent the no local return error message. Resolves: riak_repl_console.erl:288: The created fun has no local return
|
At first glance these seem ok to me, but I'm not a repl domain expert. This leaves only these remaining errors: |
|
Those will be addressed in a separate PR. |
| end, | ||
| log_stop(Command, State), | ||
| wait_ack(cancel_fullsync, #state{sitename=SiteName} = State) -> | ||
| NewState = application:unset_env(riak_repl, {progress, SiteName}), |
There was a problem hiding this comment.
This is not the correct value for NewState.
There was a problem hiding this comment.
Nice catch. This was resolved in 6bb6262.
|
I don't understand the reason for this ignore: |
|
The rest of this looks fine. |
|
As best as I could tell via Typer, the unset_env and set_env calls which are producing errors because Dialyzer feels they will never succeed, causes it to identify that the |
|
You could move the log message before the (un)set_env calls, that should shut things up without doing anything other than logging a few instructions earlier. |
Reorder log messages to prevent the incorrectly specified set_env and unset_env calls from generating false errors.
|
Addressed logging issues with e30d78f. |
Resolves:
riak_repl_console.erl:284: The created fun has no local return
riak_repl_console.erl:285: The pattern {'ok', Members} can never match the type [{string(),non_neg_integer()}]
Regardless of the correct type specifications on sync_connect and sync_connect_status, dialyzer still believes that this function can never return 'ok' because the ranch call is thought to have failed because of the improper specification. See existing ignores related to ranch_tcp.
All callers of this function use encode_obj_msg, which never returns a non-binary, so crash if that is the case.
|
Depends on basho/riak_kv#882. |
|
+1 on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the remaining dialyzer errors on repl. Flawless victory.