Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile in 17.0: clients are compiles with various OTP versions #89

Merged
merged 2 commits into from
Apr 30, 2014
Merged

compile in 17.0: clients are compiles with various OTP versions #89

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c9bd52
compile in 17.0: clients are compiles with various OTP versions
kuenishi Apr 24, 2014
de68a10
introduce version switch, to make dialyzer rather happy
kuenishi Apr 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/riak_pb_kv_codec.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
-type quorum() :: symbolic_quorum() | non_neg_integer().
-type symbolic_quorum() :: one | quorum | all | default.
-type value() :: binary().
-type metadata() :: dict().
-type metadata() :: dict:dict(binary(), binary()).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this type invalid on releases < 17.0? Furthermore, dict:dict/0 is the type in previous releases, not dict:dict/2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's invalid. I'll fix it in the following commit by introducing a sad version-specific switch. And to give nowarn_... to dialyzer we have to modify tools.mk, which probably we hope to be same across all our repositories?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you can specify the flags to use in the DIALYZER_FLAGS variable: https://github.com/basho/tools.mk/blob/master/tools.mk#L17

-type contents() :: [{metadata(), value()}].

%% @doc Convert a list of object {MetaData,Value} pairs to protocol
Expand Down