fix #936: handle slow metrics for get_put_monitor_eqc #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On slow systems the get_put_monitor_eqc test could fail due to not waiting long enough for folsom metrics updates. Add bounded wait for metrics to become non-negative before checking them against expected results. Also increase max test time from 120 to 150 to avoid test timeout on slow systems.
|
Yay! Nice work @vinoski |
|
+1 ca0dc39 |
borshop
added a commit
that referenced
this pull request
May 10, 2014
fix #936: handle slow metrics for get_put_monitor_eqc Reviewed-by: andrewjstone
|
@andrewjstone it appeared that a series of increments and decrements of the metrics had just not finished by the time the tests sampled them for comparison against expected values, and the symptom was always that the metrics had negative values when failing. My change just checks the metrics for negative values before comparing them, giving them a little more time to settle and reach their ultimate values first. |
vinoski
added a commit
that referenced
this pull request
May 10, 2014
fix #936: handle slow metrics for get_put_monitor_eqc
|
good to know, thanks @seancribbs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On slow systems the get_put_monitor_eqc test could fail due to not waiting
long enough for folsom metrics updates. Add bounded wait for metrics to
become non-negative before checking them against expected results. Also
increase max test time from 120 to 150 to avoid test timeout on slow
systems.