Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with latest riak_ensemble API #887

Merged
merged 3 commits into from
Apr 11, 2014
Merged

Conversation

jtuple
Copy link
Contributor

@jtuple jtuple commented Apr 1, 2014

This pull-request updates riak_kv to work with basho/riak_ensemble#10

This pull-request also adds some support API calls to riak_kv_ensembles that are used in some riak_tests as well as can be used for support/debugging.

@andrewjstone
Copy link
Contributor

Seeing the following dialyzer warnings:

riak_kv_vnode.erl:1021: Call to missing or unexported function riak_ensemble_backend:pong/1
riak_kv_ensembles.erl:65: Call to missing or unexported function riak_ensemble_manager:count_quorum/2
riak_kv_ensembles.erl:134: Call to missing or unexported function riak_ensemble_manager:enabled/0
riak_kv_ensembles.erl:153: Call to missing or unexported function riak_ensemble_manager:known_ensembles/0

@andrewjstone
Copy link
Contributor

==> riak_kv (xref)
Query (XC - UC) || (XU - X - B - "(cluster_info|dtrace|yz_kv|yz_stat)" : Mod)
 answer [{{riak_kv_ensembles,bootstrap_preflists,2},
          {riak_ensemble_manager,known_ensembles,0}},
         {{riak_kv_ensembles,count_quorum,0},
          {riak_ensemble_manager,count_quorum,2}},
         {{riak_kv_ensembles,maybe_bootstrap_ensembles,0},
          {riak_ensemble_manager,enabled,0}},
         {{riak_kv_vnode,handle_info,2},{riak_ensemble_backend,pong,1}}]
 did not match []
ERROR: xref failed while processing /Users/ajs/riak_ee/deps/riak_kv: rebar_abort

@andrewjstone
Copy link
Contributor

Code looks good. Once these dialyzer and xref errors are fixed, +1.

@andrewjstone
Copy link
Contributor

When I actually run with the proper riak_ensemble deps I get clean xref and dialyzer.

👍

@jtuple jtuple merged commit b6e48da into develop Apr 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants