Add yz_stat exception to xref analysis #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running xref complains about undefined calls to yz_stat because Yokozuna is not a riak_kv dependency. Since we already ignore yz_kv calls, this commit adds an exception for yz_stat calls as well. In the future, we'll either make Yokozuna a proper sub-dependency of riak_kv, or add support to dynamically registered stat callbacks for stat aggregation (eg. for /stats).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
xrefcomplains about undefined calls toyz_statbecause Yokozuna is not a riak_kv dependency.Since we already ignore
yz_kvcalls, this commit adds an exception foryz_statcalls as well.In the future, we'll either make Yokozuna a proper sub-dependency of riak_kv, or add support to dynamically registered stat callbacks for stat aggregation (eg. for
/stats).For reference, the two calls into
yz_statare on riak_kv_stat_bc.erl#L159 and riak_kv_wm_stats.erl#L89.