Add timer:sleep()-based throttle to riak_kv_exchange_fsm:read_repair_keydiff() #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These include:
* Add timer:sleep()-based throttle to riak_kv_exchange_fsm:read_repair_keydiff()
The throttle part is easy: a 1-liner. The rest is the infrastructure
to poll each node for its maximum vnode mailbox queue length, pick the
worst one, calculate a sleep time based on a list of {Q_length, SleepMSec},
and communicate via time-honored application env vars.
The only hot code path that reads the ETS table for app env vars is
riak_kv_exchange_fsm:read_repair_keydiff() itself, and since it is
doing a full KV get FSM plus other stuff, the extra heat on the hot
path is insignificant.
* Fix non-eunit compilation error
* Add kill switch
* Use async worker proc to query vnode status for AAE throttle check
|
Derp, I didn't see Sean's comments from two days ago. GitHub's notifications don't work like I think they do, sorry. |
|
Per @jtuple, I'm merging now. I'll address the Cuttlefish naming thing later, sorry, @seancribbs! There's a matter of having 2 throttles now, one for tree building and this one for exchange, and perhaps they ought to be disambiguated code-wise for future maintenance? But if I go changing function names in riak_kv_entropy_manager.erl, then there's a big mess o' renaming to do ... am willing to debate the merits of doing that, when we return from end-of-year breaks. |
slfritchie
added a commit
that referenced
this pull request
Dec 24, 2013
Add timer:sleep()-based throttle to riak_kv_exchange_fsm:read_repair_keydiff()
|
@slfritchie It's fine, we have plans to do more renaming anyway. Just wanted to save us a little work down the road... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Develop branch version of #754