Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode object dot for JS map-reduce #782

Merged
merged 1 commit into from
Dec 24, 2013
Merged

Conversation

rzezeski
Copy link
Contributor

There is no need to encode the dot for JavaScript map-reduce. It is an
internal thing and doesn't need to be exposed.

This fixes #779.

I see 6 eunit failures both on this branch and develop.

There is no need to encode the dot for JavaScript map-reduce. It is an
internal thing and doesn't need to be exposed.
@ghost ghost assigned russelldb Dec 24, 2013
@russelldb
Copy link
Member

WFM +1. Nice catch. Thanks.

@russelldb
Copy link
Member

Actually, second thoughts, I think I might have to be smarter and binary encode the dot. What about downgrades? If data is written with a dot, then the node downgraded, this fix won't be there, but the dot still will be.

@rzezeski
Copy link
Contributor Author

Yea, I didn't think of downgrade case. We should revisit this after holidays. Merging for now so tests will work in 2.0.

rzezeski added a commit that referenced this pull request Dec 24, 2013
Don't encode object dot for JS map-reduce
@rzezeski rzezeski merged commit c04b94f into develop Dec 24, 2013
@jonmeredith
Copy link
Contributor

@rzezeski can you open an issue to track?

On Tue, Dec 24, 2013 at 8:17 AM, Ryan Zezeski notifications@github.comwrote:

Yea, I didn't think of downgrade case. We should revisit this after
holidays. Merging for now so tests will work in 2.0.


Reply to this email directly or view it on GitHubhttps://github.com//pull/782#issuecomment-31174740
.

Jon Meredith
VP, Engineering
Basho Technologies, Inc.
jmeredith@basho.com

@seancribbs
Copy link
Contributor

@jonmeredith We've put a known issue in release notes for the downgrade problem.

@jonmeredith
Copy link
Contributor

Ok, great. It's good to have in both places - issues get reviewed more
often than release notes.

On Tue, Dec 24, 2013 at 8:41 AM, Sean Cribbs notifications@github.comwrote:

@jonmeredith https://github.com/jonmeredith We've put a known issue in
release notes for the downgrade problem.


Reply to this email directly or view it on GitHubhttps://github.com//pull/782#issuecomment-31175550
.

Jon Meredith
VP, Engineering
Basho Technologies, Inc.
jmeredith@basho.com

@jrwest
Copy link
Contributor

jrwest commented Dec 24, 2013

its also been added to the kill bill for true N = 3 safety!

@rzezeski rzezeski modified the milestones: 2.0-beta, 2.0 Mar 25, 2014
@seancribbs seancribbs deleted the bugfix/rz/dot-js-mr branch April 1, 2015 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOWNGRADE?] The new dvv stuff doesn't play well with JS map-reduce
5 participants