Strong Consistency and Other Riak KV Bucket Validators #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bucket type that is consistent must remain so (the property is immutable) and the n_val of the type may not be changed (for the type or its buckets). A type that has consistent=true is consisdered to be strongly-cosnsitent regardless of the values of other properties including the datatype property -- strong-consistency may use this property for its own purposes in the future. Untyped buckets (default bucket type) cannot be strongly consistent. The eqc tests have been updated to reflect the changes. Other Notes: * The consistent property is validated in two paths depending on if the type is consistent or not. This is a bit meh. * It is assumed that the value of allow_mult does not matter to strong consistency and thus it is not validated (besides being a valid boolean) for this path * The datatype property is not validated if the type is strongly-cosnsitent. This is because, what the property will mean is still undefined. * I may have butchered prop_merges() a bit (the most at least). As validation grows we may want to re-think how we build the expected set in the property
This was referenced Dec 19, 2013
|
Sanity check went fine. Merging |
jrwest
added a commit
that referenced
this pull request
Dec 19, 2013
Strong Consistency and Other Riak KV Bucket Validators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains both #667 and #747 merged and rebased on a recent develop. The PRs mentioned have the +1s. I'm going to merge this PR, shortly after a final sanity check.