Merge CRDTs inside riak_object merge #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Well it means no CRDT siblings on disk. Previously CRDTs were merged only when a CRDT Operation was performed from the CRDT API endpoints. This means read repair, AAE, and repl, could all cause siblings on disk. With the addition of DVV style causality, we need to make a choice about CRDTs. We don't have DVVSets and the anonymous list. So CRDTs either have to merge Dots into a mini-version-vector, or not have dots. If CRDTs don't have dots, so their values always survive a merge, then they are subject to repl induced sibling-explosion (possibly) Merging in riak_object:merge solves that issue. As an added benefit it also means that Yokozuna indexing of CRDTs will just work. I'd really appreciate a performance comparision between this and the plain DVV branch, and the pre-DVV stuff for 2.0.
|
Decided to merge this to the branch and have both as a single PR for DVV in Riak |
russelldb
added a commit
that referenced
this pull request
Dec 13, 2013
Merge CRDTs inside riak_object merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Well it means no CRDT siblings on disk. Previously CRDTs
were merged only when a CRDT Operation was performed from the CRDT
API endpoints. This means read repair, AAE, and repl, could all cause
siblings on disk.
With the addition of DVV style causality, we need to make a choice
about CRDTs. We don't have DVVSets and the anonymous list. So CRDTs
either have to merge Dots into a mini-version-vector, or not have dots.
If CRDTs don't have dots, so their values always survive a merge,
then they are subject to repl induced sibling-explosion (possibly)
Merging in riak_object:merge solves that issue.
As an added benefit it also means that Yokozuna indexing of CRDTs
will just work.
I'd really appreciate a performance comparision between this and
the plain DVV branch, and the pre-DVV stuff for 2.0.