make riak_kv_test_util app startup less brittle #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit c3ebdc9 I added some missing apps to the list of apps in riak_kv_test_util that need to be started for some riak_kv testing. Unfortunately trying to list out the entire app dependency tree in that module is very brittle and is to easy to forget to update if a new app dependency is added in the future. Modify that list to eliminate the lower level apps and instead just list the obvious higher-level apps, and add a new function that starts each application's dependencies before starting the app itself. Also change the riak_kv_test_util setup function to return the list of all apps started, and change the cleanup function to take that list of apps and stop them all.
|
👍, this resolves the test stalls. |
cmeiklejohn
added a commit
that referenced
this pull request
Nov 23, 2013
make riak_kv_test_util app startup less brittle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit c3ebdc9 I added some missing apps to the list of apps in
riak_kv_test_util that need to be started for some riak_kv
testing. Unfortunately trying to list out the entire app dependency tree in
that module is very brittle and is to easy to forget to update if a new app
dependency is added in the future. Modify that list to eliminate the lower
level apps and instead just list the obvious higher-level apps, and add a
new function that starts each application's dependencies before starting
the app itself. Also change the riak_kv_test_util setup function to return
the list of all apps started, and change the cleanup function to take that
list of apps and stop them all.