Error reason for put is not propagated back to client #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -1055,8 +1055,8 @@ prepare_put(#state{vnodeid=VId, | |||
| BProps)) | |||
| end, | |||
| case handle_crdt(Coord, CRDTOp, VId, ObjToStore) of | |||
| {error, _}=E -> | |||
| {{fail, Idx, E}, PutArgs};%% NOTE subverts ReqId to Error | |||
| {error, E}=E -> | |||
There was a problem hiding this comment.
What gets sent to the fsm, can you overload E like this in one statement?
There was a problem hiding this comment.
That is not what I saw in my brain when I edited this. I forgot to delete the final =E
|
👍 works and everything :D |
A couple of feature writers independently discovered that the vnode reply included an unused request id (the sender already has the request id and ignored this one) and used that to return error conditions. That happens for overload and CRDT operations. This change makes the reply officially contain an error reason instead of the unuse request id. Notice that delete replies were changed, but they are not used right now. That should be harmless and makes it all consistent.
engelsanchez
added a commit
that referenced
this pull request
Oct 2, 2013
…reason Error reason for put is not propagated back to client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a put error, the code in riak_kv_vnode will ignore the error and reply with a request id. We don't think this request id is necessary at all. We need to send back the error reason. The overload code is already replacing that request id with the overload token when it triggers.