Modify the version 1 format to support bucket types #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new keydir format has 2 forms, as follows <<Version:7, 0:1, BucketSize:16/integer, Bucket/binary, Key/binary>> <<Version:7, 1:1, TypeSize:16/integer, Type/binary, BucketSize:16/integer, Bucket/binary, Key/binary>> The 8th bit of the binary is the bit that indicates if a bucket type is present, and tells the decoder which form to expect.
evanmcc
added a commit
that referenced
this pull request
Sep 19, 2013
Modify the version 1 format to support bucket types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new keydir format has 2 forms, as follows
The 8th bit of the binary is the bit that indicates if a bucket type is
present, and tells the decoder which form to expect.
Both the eunit tests for riak_kv_bitcask_backend and the bucket_types riak_test pass against this branch.
cc @evanmcc