Add security to Riak #662
Merged
Add security to Riak #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| get_required_permissions(Inputs, _Query) -> | ||
| InputPermissions = case Inputs of | ||
| Bucket when is_binary(Bucket) -> | ||
| [{"riak_kv.list_keys", {<<"default">>, Bucket}}, |
There was a problem hiding this comment.
The sad thing about having all these default bucket name literals spread out through the code is that search and replace to change them into a macro will only miss the ones with typos, the only ones we need to fix :(
|
From a usage standpoint and the understanding there is a lot of testing that's going to happen off of pre2, I'm +1 for this to go in. |
|
+1 here too. mapreduce is clear, and boilerplate code looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new security APIs in riak_core to do permissions checking on various riak API endpoints.
It currently does not secure ALL of the APIs, specifically stats, link walking and the 'CS bucket' APIs are not covered.
See also basho/riak#355