Using riak_pipe for Map Reduce task may return inconsistent results when one of cluster node is down. #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce phase must be started on live node.
If we can't send reduce result to output we must generate an error, otherwise we will return inconsistent results.
beerriot
added a commit
to basho/riak_test
that referenced
this pull request
Feb 1, 2013
This test is based off one submitted by Alexander Gunin to the riak-users mailing list as an issue reproducer. [http://lists.basho.com/pipermail/riak-users_lists.basho.com/2013-January/010896.html]
beerriot
added a commit
that referenced
this pull request
Feb 2, 2013
Builds on commit in #475 with more documentation, variable name cleanup, and a more failure-tolerant up-vnode-finder strategy.
beerriot
added a commit
that referenced
this pull request
Feb 4, 2013
Squashed commit of the following: commit 0c07454 Author: Bryan Fink <bryan@basho.com> Date: Sat Feb 2 10:17:43 2013 -0500 cleanup and rework contant reduce hash Builds on commit in #475 with more documentation, variable name cleanup, and a more failure-tolerant up-vnode-finder strategy. commit 58040e8 Author: Dreyk <gunin@satissoft.ru> Date: Fri Feb 1 13:44:49 2013 +0400 Update src/riak_kv_mrc_pipe.erl Reduce phase must be started on live node.
|
As the github history indicates, I cleaned up the first patch in this PR (for the constant reduce hash) for incorporation into Riak's 1.3 RC2. We'll review the second patch (for handling reduce phase errors) separately. Thank you! |
|
@beerriot Did the second patch ever get merged? |
|
@evanmcc Nope, it sure didn't. Want to submit a PR? |
|
Pulling PRs out of the freezer ... Hrm, looks like an impasse. Does the 2nd patch exist someplace? |
|
I don't think so. It'd be a process of looking at this PR, and Bryan's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using riak_pipe for Map Reduce task may return inconsistent results(for example empty list,however all data are available).
See http://lists.basho.com/pipermail/riak-users_lists.basho.com/2013-January/010870.html