add wm code for getting active preflist #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2015
zeeshanlakhani
force-pushed
the
feature/zl/add-wm-code-for-getting-active-preflist
branch
from
af18020
to
bef6121
Compare
| ]). | ||
|
|
||
| -record(ctx, { | ||
| api_version :: integer(), %% version of the API to use. |
There was a problem hiding this comment.
Not sure copying this state record wholesale is necessary. E.g., you don't need:
api_version(always 3 or whatever, this is a new api)client(you're only getting bucket props)prefix(again related to ancient API)riak(this is just legacy cruft, we only "connect" locally)method(are you supporting anything other than GET/HEAD?)
There was a problem hiding this comment.
Yeah, I was gonna ask. Will update.
zeeshanlakhani
force-pushed
the
feature/zl/add-wm-code-for-getting-active-preflist
branch
3 times, most recently
from
9c289ad
to
006d7bb
Compare
| @@ -186,8 +188,17 @@ check_bucket_type(Type) -> | |||
| error | |||
| end. | |||
|
|
|||
| -spec maybe_create_bucket_type(binary(), binary()) -> binary() | {binary(), binary()}. | |||
| -spec maybe_create_bucket_type(binary(), binary()) -> riak_core_bucket:bucket(). | |||
There was a problem hiding this comment.
This spec looks clearly violated if one can pass undefined.
There was a problem hiding this comment.
hmm, yeah, odd. fixing and will rerun.
zeeshanlakhani
force-pushed
the
feature/zl/add-wm-code-for-getting-active-preflist
branch
from
006d7bb
to
7adeae4
Compare
add wm module and pb interface for GETing (and encoding) active preflist
zeeshanlakhani
force-pushed
the
feature/zl/add-wm-code-for-getting-active-preflist
branch
from
7adeae4
to
9fede91
Compare
|
👍 9fede91 |
borshop
added a commit
that referenced
this pull request
Feb 27, 2015
…g-active-preflist add wm code for getting active preflist Reviewed-by: seancribbs
|
@borshop merge |
zeeshanlakhani
deleted the
feature/zl/add-wm-code-for-getting-active-preflist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Bors will fail until basho/riak_pb#105 and basho/riak_api#79 is reviewed/merged.
Update for webmachine/pb interface.
Description
Part of RIAK-1481.
The active preflist will return primary/fallback partitions and nodes for the available nodes at the time of query. Primary/fallback will be annotated.
This involves updates to our RiakKV WB code, RiakPB, Riak-Erlang-Http-Client, Riak-Erlang-Client.
*The impetus for adding this to the API started with a mailing list question answered by Charlie Voiselle, http://lists.basho.com/pipermail/riak-users_lists.basho.com/2015-January/016527.html, which involved a snippet of code that we've given clients multiple times. This was then discussed with Russell Brown on HipChat, https://basho.hipchat.com/history/room/867200/2015/01/13?q=enterprising&t=rid-867200#12:23:22.
Other PRs in the series: