Skip to content

Commit

Permalink
update riak_kv_schema_tests for bg manager being disabled by default
Browse files Browse the repository at this point in the history
  • Loading branch information
@jrwest
jrwest committed Jun 2, 2014
1 parent f3a64ae commit 31d467d
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions test/riak_kv_schema_tests.erl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ basic_schema_test() ->
cuttlefish_unit:assert_not_configured(Config, "riak_core.default_bucket_props.postcommit"),
cuttlefish_unit:assert_config(Config, "riak_core.default_bucket_props.dvv_enabled", false),
cuttlefish_unit:assert_config(Config, "riak_dt.binary_compression", 1),
cuttlefish_unit:assert_config(Config, "riak_kv.handoff_use_background_manager", true),
cuttlefish_unit:assert_config(Config, "riak_kv.aae_use_background_manager", true),
cuttlefish_unit:assert_config(Config, "riak_kv.handoff_use_background_manager", false),
cuttlefish_unit:assert_config(Config, "riak_kv.aae_use_background_manager", false),
ok.

override_non_multi_backend_schema_test() ->
Expand Down Expand Up @@ -117,8 +117,8 @@ override_non_multi_backend_schema_test() ->
{["buckets", "default", "precommit"], "module:function javascriptFunction"},
{["buckets", "default", "postcommit"], "module2:function2"},
{["datatypes", "compression_level"], "off"},
{["handoff", "use_background_manager"], off},
{["anti_entropy", "use_background_manager"], off}
{["handoff", "use_background_manager"], on},
{["anti_entropy", "use_background_manager"], on}
],

Config = cuttlefish_unit:generate_templated_config(
Expand Down Expand Up @@ -185,8 +185,8 @@ override_non_multi_backend_schema_test() ->
]}
]),
cuttlefish_unit:assert_config(Config, "riak_dt.binary_compression", false),
cuttlefish_unit:assert_config(Config, "riak_kv.handoff_use_background_manager", false),
cuttlefish_unit:assert_config(Config, "riak_kv.aae_use_background_manager", false),
cuttlefish_unit:assert_config(Config, "riak_kv.handoff_use_background_manager", true),
cuttlefish_unit:assert_config(Config, "riak_kv.aae_use_background_manager", true),

ok.

Expand Down

6 comments on commit 31d467d

@reiddraper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 yay something finally passes without other tests getting in the way

@borshop
Copy link
Contributor

@borshop borshop commented on 31d467d Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from reiddraper
at 31d467d

@borshop
Copy link
Contributor

@borshop borshop commented on 31d467d Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging basho/riak_kv/features/jrw/disable-bg-mgr = 31d467d into borshop-integration-964-features/jrw/disable-bg-mgr

@borshop
Copy link
Contributor

@borshop borshop commented on 31d467d Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basho/riak_kv/features/jrw/disable-bg-mgr = 31d467d merged ok, testing candidate = f9a443e

@borshop
Copy link
Contributor

@borshop borshop commented on 31d467d Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/1435
success: http://buildbot.bos1/builders/test-riak_kv/builds/1435
success: http://buildbot.bos1/builders/test-riak_kv/builds/1435
success: http://buildbot.bos1/builders/test-riak_kv/builds/1435
success: http://buildbot.bos1/builders/test-riak_kv/builds/1435
success: http://buildbot.bos1/builders/test-riak_kv/builds/1435
success: http://buildbot.bos1/builders/test-riak_kv/builds/1435
success: http://buildbot.bos1/builders/test-riak_kv/builds/1435

@borshop
Copy link
Contributor

@borshop borshop commented on 31d467d Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding develop to borshop-integration-964-features/jrw/disable-bg-mgr = f9a443e

Please sign in to comment.