Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless script #24

Merged
merged 1 commit into from
May 9, 2014
Merged

remove useless script #24

merged 1 commit into from
May 9, 2014

Conversation

binarytemple
Copy link
Contributor

That command is hard-coded, I don't know what the purpose of the shell script is, it seems to be leftover cruft.

The JMX endpoint launching is actually hard coded in Erlang.

jmx() ->
    %% We're going to pull all of the settings out of the app.config
    %% again, in case they've changed
    {ok, JMXPort} = application:get_env(riak_jmx, port),

    %% Spin up the JMX server
    JMXFormatString = "java -server "
        ++ "-Dcom.sun.management.jmxremote.authenticate=false "
        ++ "-Dcom.sun.management.jmxremote.ssl=false "
        ++ "-Dcom.sun.management.jmxremote.port=~s "
        ++ "-jar riak_jmx.jar ~s ~s ~s",

    {ok, JMXRefreshRate} = application:get_env(riak_jmx, jmx_refresh_seconds),

    Cmd = ?FMT(JMXFormatString, [integer_to_list(JMXPort),
                                 node(), erlang:get_cookie(),
                                 integer_to_list(JMXRefreshRate)]),
    lager:info(Cmd),
    start_sh(Cmd, priv_dir()).

@binarytemple
Copy link
Contributor Author

@binarytemple
Copy link
Contributor Author

@michellep forgot in mumble that I'd already created github ticket for this unused script.

@cmeiklejohn cmeiklejohn added this to the 2.0-RC milestone May 9, 2014
@cmeiklejohn
Copy link
Contributor

Adding to the 2.0-RC milestone.

@cmeiklejohn
Copy link
Contributor

👍

cmeiklejohn added a commit that referenced this pull request May 9, 2014
@cmeiklejohn cmeiklejohn merged commit 7a910f9 into develop May 9, 2014
@cmeiklejohn cmeiklejohn deleted the remove_useless_script branch May 9, 2014 16:51
@binarytemple
Copy link
Contributor Author

thx @cmeiklejohn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants