Remove legacy search, continued

[nickelization]

This removes one more bit of code that we missed in #906. I posted about it in the review comments there before I realized the previous PR had already been merged.

[thumbot]

Thanks @nickelization!

Settings

---
minimum_reviewers: 2
merge: true
build_steps:
- make clean
- make deps
- make compile
- make test
- make xref
- make dialyzer
org_mode: true
timeout: 1800

[thumbot]

nem-remove-more-legacy-search 0a021ae	➡️	develop 191c4fa	✅ completed

Looks good! 👍

✅ MERGE

Started at: 2017-03-10 12:08
Duration: 1 seconds.
Result: OK
Message: Merge Success: nem-remove-more-legacy-search 0a021ae onto target branch: develop 191c4fa
Exit Code: OK

📄

  Merge made by the 'recursive' strategy.
 src/riak_core_console.erl | 3 ---
 1 file changed, 3 deletions(-)

---

✅ MAKE_CLEAN

Started at: 2017-03-10 12:08
Duration: 1 seconds.
Result: OK
Message: OK
Exit Code: 0

📄

cd /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae; make clean




  ./rebar clean
==> develop.191c4fa.nem-remove-more-legacy-search.0a021ae (clean)

---

✅ MAKE_DEPS

Started at: 2017-03-10 12:08
Duration: 12 seconds.
Result: OK
Message: OK
Exit Code: 0

📄

cd /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae; make deps




  ./rebar get-deps
==> develop.191c4fa.nem-remove-more-legacy-search.0a021ae (get-deps)
Pulling lager from {git,"git://github.com/basho/lager.git",{tag,"3.2.4"}}
Cloning into 'lager'...
Pulling poolboy from {git,"git://github.com/basho/poolboy.git",
                          {tag,"0.8.1p3"}}
Cloning into 'poolboy'...
Pulling basho_stats from {git,"git://github.com/basho/basho_stats.git",
                              {tag,"1.0.3"}}
Cloning into 'basho_stats'...
Pulling riak_sysmon from {git,"git://github.com/basho/riak_sysmon.git",
                              {tag,"2.1.4"}}
Cloning into 'riak_sysmon'...
Pulling eleveldb from {git,"git://github.com/basho/eleveldb.git",
                           {tag,"2.0.32"}}
Cloning into 'eleveldb'...
Pulling riak_ensemble from {git,"git://github.com/basho/riak_ensemble",
                                {tag,"2.1.6"}}
Cloning into 'riak_ensemble'...
Pulling pbkdf2 from {git,"git://github.com/basho/erlang-pbkdf2.git",
                         {tag,"2.0.0"}}
Cloning into 'pbkdf2'...
Pulling exometer_core from {git,"git://github.com/basho/exometer_core.git",
                                {tag,"1.0.0-basho9"}}
Cloning into 'exometer_core'...
Pulling clique from {git,"https://github.com/basho/clique.git",{tag,"0.3.8"}}
Cloning into 'clique'...
==> lager (get-deps)
Pulling goldrush from {git,"https://github.com/basho/goldrush.git",
                           {tag,"0.1.9"}}
Cloning into 'goldrush'...
==> goldrush (get-deps)
==> poolboy (get-deps)
==> basho_stats (get-deps)
==> riak_sysmon (get-deps)
Pulling cuttlefish from {git,"https://github.com/basho/cuttlefish.git",
                             {tag,"2.0.10"}}
Cloning into 'cuttlefish'...
==> cuttlefish (get-deps)
Pulling getopt from {git,"https://github.com/basho/getopt.git",{tag,"v0.8.2"}}
Cloning into 'getopt'...
Pulling neotoma from {git,"https://github.com/basho/neotoma.git",
                          {tag,"1.7.3"}}
Cloning into 'neotoma'...
==> getopt (get-deps)
==> neotoma (get-deps)
==> eleveldb (get-deps)
Cloning into 'leveldb'...
Note: checking out '2.0.31'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at e6a2939... add (int) cast to fix compile errors on 10 of 16 platforms ... argh.
==> riak_ensemble (get-deps)
==> pbkdf2 (get-deps)
==> src (get-deps)
==> exometer_core (get-deps)
Pulling parse_trans from {git,"git://github.com/basho/parse_trans.git",
                              {tag,"2.9.2p1"}}
Cloning into 'parse_trans'...
Pulling folsom from {git,"git://github.com/basho/folsom.git",{tag,"0.7.4p5"}}
Cloning into 'folsom'...
Pulling setup from {git,"git://github.com/basho/setup.git",{tag,"1.4"}}
Cloning into 'setup'...
==> parse_trans (get-deps)
Pulling edown from {git,"git://github.com/basho/edown.git",{tag,"0.8.1"}}
Cloning into 'edown'...
==> edown (get-deps)
==> folsom (get-deps)
Pulling bear from {git,"git://github.com/basho/bear.git",{tag,"0.1.3p1"}}
Cloning into 'bear'...
Pulling meck from {git,"git://github.com/basho/meck.git",{tag,"0.8.2"}}
Cloning into 'meck'...
==> bear (get-deps)
==> meck (get-deps)
==> setup (get-deps)
==> clique (get-deps)

---

✅ MAKE_COMPILE

Started at: 2017-03-10 12:08
Duration: 32 seconds.
Result: OK
Message: OK
Exit Code: 0

📄

cd /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae; make compile




  
  
... Snipped 636 lines ...
lude -I. -I./include -fno-builtin-memcmp -pthread -DOS_LINUX -DLEVELDB_PLATFORM_POSIX -DSNAPPY  -DLEVELDB_VSN="2.0.31" -O2 -g -DNDEBUG     -fPIC tools/perf_dump.cc -o perf_dump -L . -Wl,-non_shared -lleveldb -Wl,-call_shared -m64  -L/tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/system/lib -pthread -lrt -Wl,-non_shared -lsnappy -Wl,-call_shared
c++ -m64  -Wall -O3 -fPIC -I /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/system/include -I. -I./include -fno-builtin-memcmp -pthread -DOS_LINUX -DLEVELDB_PLATFORM_POSIX -DSNAPPY  -DLEVELDB_VSN="2.0.31" -O2 -g -DNDEBUG     -fPIC tools/sst_rewrite.cc -o sst_rewrite -L . -Wl,-non_shared -lleveldb -Wl,-call_shared -m64  -L/tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/system/lib -pthread -lrt -Wl,-non_shared -lsnappy -Wl,-call_shared
c++ -m64  -Wall -O3 -fPIC -I /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/system/include -I. -I./include -fno-builtin-memcmp -pthread -DOS_LINUX -DLEVELDB_PLATFORM_POSIX -DSNAPPY  -DLEVELDB_VSN="2.0.31" -O2 -g -DNDEBUG     -fPIC tools/sst_scan.cc -o sst_scan -L . -Wl,-non_shared -lleveldb -Wl,-call_shared -m64  -L/tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/system/lib -pthread -lrt -Wl,-non_shared -lsnappy -Wl,-call_shared
make[1]: Leaving directory `/tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/leveldb'
Compiled src/eleveldb_bump.erl
Compiled src/eleveldb.erl
Compiling c_src/eleveldb.cc
Compiling c_src/refobjects.cc
Compiling c_src/workitems.cc
==> riak_ensemble (compile)
Compiled src/riak_ensemble_backend.erl
Compiled src/riak_ensemble_sup.erl
Compiled src/synctree_orddict.erl
Compiled src/riak_ensemble_client.erl
Compiled src/riak_ensemble_router.erl
Compiled src/riak_ensemble_config.erl
Compiled src/riak_ensemble_router_sup.erl
Compiled src/synctree.erl
Compiled src/riak_ensemble_lease.erl
Compiled src/riak_ensemble_test.erl
Compiled src/synctree_leveldb.erl
Compiled src/riak_ensemble_exchange.erl
Compiled src/riak_ensemble_manager.erl
Compiled src/riak_ensemble_root.erl
Compiled src/riak_ensemble_save.erl
Compiled src/riak_ensemble_clock.erl
Compiled src/riak_ensemble_peer_worker.erl
Compiled src/riak_ensemble_app.erl
Compiled src/riak_ensemble_basic_backend.erl
Compiled src/riak_ensemble_state.erl
Compiled src/riak_ensemble_storage.erl
Compiled src/riak_ensemble_peer_tree.erl
Compiled src/riak_ensemble_peer_sup.erl
Compiled src/synctree_ets.erl
Compiled src/riak_ensemble_util.erl
Compiled src/riak_ensemble_msg.erl
Compiled src/riak_ensemble_peer.erl
Compiling c_src/riak_ensemble_clock.c
==> pbkdf2 (compile)
Compiled src/pbkdf2.erl
==> edown (compile)
Compiled src/edown_make.erl
Compiled src/edown_lib.erl
Compiled src/edown_xmerl.erl
Compiled src/edown_doclet.erl
Compiled src/edown_layout.erl
==> parse_trans (compile)
Compiled src/parse_trans.erl
Compiled src/parse_trans_pp.erl
Compiled src/parse_trans_codegen.erl
Compiled src/parse_trans_mod.erl
Compiled src/ct_expand.erl
Compiled src/exprecs.erl
==> bear (compile)
Compiled src/bear.erl
==> meck (compile)
Compiled src/meck_cover.erl
Compiled src/meck_expect.erl
Compiled src/meck_matcher.erl
Compiled src/meck_args_matcher.erl
Compiled src/meck_history.erl
Compiled src/meck.erl
Compiled src/meck_code_gen.erl
Compiled src/meck_util.erl
Compiled src/meck_code.erl
Compiled src/meck_ret_spec.erl
Compiled src/meck_proc.erl
==> folsom (compile)
Compiled src/folsom_sample_slide_sup.erl
Compiled src/folsom_sample_slide.erl
Compiled src/folsom_metrics_histogram.erl
Compiled src/folsom_ewma.erl
Compiled src/folsom_sample_none.erl
Compiled src/folsom_sample_exdec.erl
Compiled src/folsom_metrics_histogram_ets.erl
Compiled src/folsom_metrics_duration.erl
Compiled src/folsom.erl
Compiled src/folsom_sample.erl
Compiled src/folsom_metrics_meter_reader.erl
Compiled src/folsom_metrics.erl
Compiled src/folsom_vm_metrics.erl
Compiled src/folsom_sample_slide_uniform.erl
Compiled src/folsom_metrics_counter.erl
Compiled src/folsom_metrics_spiral.erl
Compiled src/folsom_meter_timer_server.erl
Compiled src/folsom_metrics_history.erl
Compiled src/folsom_sample_slide_server.erl
Compiled src/folsom_sup.erl
Compiled src/folsom_ets.erl
Compiled src/folsom_utils.erl
Compiled src/folsom_metrics_gauge.erl
Compiled src/folsom_metrics_meter.erl
Compiled src/folsom_sample_uniform.erl
==> setup (compile)
Compiled src/setup_lib.erl
Compiled src/setup_gen.erl
Compiled src/setup.erl
==> edown (escriptize)
==> setup (escriptize)
==> src (compile)
==> exometer_core (compile)
Compiled src/exometer_igor.erl
Compiled src/exometer_util.erl
Compiled src/exometer_entry.erl
Compiled src/exometer_probe.erl
Compiled src/exometer_report.erl
Compiled src/exometer_folsom_monitor.erl
Compiled src/exometer_folsom.erl
Compiled src/exometer_report_lager.erl
Compiled src/exometer_duration.erl
Compiled src/exometer_function.erl
Compiled src/exometer_core_sup.erl
Compiled src/exometer_slide.erl
Compiled src/exometer_slot_slide.erl
Compiled src/exometer_report_tty.erl
Compiled src/exometer_proc.erl
Compiled src/exo_montest.erl
Compiled src/exometer_cache.erl
Compiled src/exometer_spiral.erl
Compiled src/exometer_cpu.erl
Compiled src/exometer_alias.erl
Compiled src/exometer_shallowtree.erl
Compiled src/exometer_admin.erl
Compiled src/exometer_uniform.erl
Compiled src/exometer_info.erl
Compiled src/exometer.erl
Compiled src/exometer_core_app.erl
Compiled src/exometer_histogram.erl
==> clique (compile)
Compiled src/clique_writer.erl
Compiled src/clique_handler.erl
Compiled src/clique_test_group_leader.erl
Compiled src/clique_table.erl
Compiled src/clique_config.erl
Compiled src/clique_json_writer.erl
Compiled src/clique.erl
Compiled src/clique_typecast.erl
Compiled src/clique_status.erl
Compiled src/clique_human_writer.erl
Compiled src/clique_usage.erl
Compiled src/clique_error.erl
Compiled src/clique_manager.erl
Compiled src/clique_nodes.erl
Compiled src/clique_sup.erl
Compiled src/clique_app.erl
Compiled src/clique_parser.erl
Compiled src/clique_csv_writer.erl
Compiled src/clique_command.erl
Compiled src/clique_spec.erl
==> develop.191c4fa.nem-remove-more-legacy-search.0a021ae (compile)
Compiled src/gen_nb_server.erl
Compiled src/riak_core_gen_server.erl
Compiled src/riak_core_stat_xform.erl
Compiled src/riak_core_broadcast_handler.erl
Compiled src/riak_core_vnode_worker_pool.erl
Compiled src/chash.erl
Compiled src/riak_core_format.erl
Compiled src/riak_core_broadcast.erl
Compiled src/riak_core_ring_manager.erl
Compiled src/riak_core_handoff_sender_sup.erl
Compiled src/riak_core_dist_mon.erl
Compiled src/chashbin.erl
Compiled src/riak_core_vnode_proxy.erl
Compiled src/riak_core_status.erl
Compiled src/riak_core_repair.erl
Compiled src/riak_core_metadata_exchange_fsm.erl
Compiled src/riak_core_claim_sim.erl
Compiled src/riak_core_mochiglobal.erl
Compiled src/dvvset.erl
Compiled src/riak_core_vnode_manager.erl
Compiled src/riak_core_bucket.erl
Compiled src/vclock.erl
Compiled src/riak_core_bg_manager.erl
Compiled src/riak_core_node_watcher.erl
Compiled src/riak_core_dtrace.erl
Compiled src/riak_core_tracer.erl
Compiled src/riak_core_vnode_sup.erl
Compiled src/riak_core_test_util.erl
Compiled src/riak_core_sup.erl
Compiled src/riak_core_handoff_sup.erl
Compiled src/riak_core_nodeid.erl
Compiled src/riak_core_vnode_proxy_sup.erl
Compiled src/riak_core_stat.erl
Compiled src/hashtree.erl
Compiled src/riak_core_tcp_mon.erl
Compiled src/riak_core_handoff_listener.erl
Compiled src/riak_core_cli_registry.erl
Compiled src/riak_core_stat_calc_sup.erl
Compiled src/riak_core_app.erl
Compiled src/riak_core_util.erl
Compiled src/riak_core_ring_util.erl
Compiled src/riak_core_console_table.erl
Compiled src/riak_core_cinfo_core.erl
Compiled src/supervisor_pre_r14b04.erl
Compiled src/riak_core_cluster_cli.erl
Compiled src/riak_core_net_ticktime.erl
Compiled src/riak_core_coverage_plan.erl
Compiled src/riak_core_send_msg.erl
Compiled src/riak_core_throttle.erl
Compiled src/riak_core_ring.erl
Compiled src/hashtree_tree.erl
Compiled src/riak_core_metadata.erl
Compiled src/riak_core_stat_q.erl
Compiled src/riak_core_vnode_master.erl
Compiled src/riak_core_table_owner.erl
Compiled src/process_proxy.erl
Compiled src/riak_core_ring_handler.erl
Compiled src/riak_core_exo_monitor.erl
Compiled src/riak_core_claim_util.erl
Compiled src/riak_core_stat_calc_proc.erl
Compiled src/riak_core_metadata_object.erl
Compiled src/riak_core_eventhandler_sup.erl
Compiled src/riak_core_handoff_listener_sup.erl
Compiled src/riak_core_sysmon_minder.erl
Compiled src/riak_core_pw_auth.erl
Compiled src/app_helper.erl
Compiled src/riak_core_stat_sup.erl
Compiled src/riak_core_node_watcher_events.erl
Compiled src/riak_core_sysmon_handler.erl
Compiled src/riak_core_handoff_cli.erl
Compiled src/riak_core_console.erl
Compiled src/riak_core_bucket_props.erl
Compiled src/riak_core_metadata_manager.erl
Compiled src/riak_core_vnode_worker.erl
Compiled src/bloom.erl
Compiled src/riak_core_metadata_hashtree.erl
Compiled src/riak_core_handoff_status.erl
Compiled src/riak_core_handoff_sender.erl
Compiled src/riak_core_ring_events.erl
Compiled src/riak_core_gossip.erl
Compiled src/riak_core_coverage_fsm.erl
Compiled src/riak_core_claimant.erl
Compiled src/riak_core_ssl_util.erl
Compiled src/riak_core_stats_sup.erl
Compiled src/riak_core_bucket_type.erl
Compiled src/riak_core_security.erl
Compiled src/riak_core_handoff_receiver_sup.erl
Compiled src/riak_core_handoff_receiver.erl
Compiled src/riak_core_claim.erl
Compiled src/riak_core_new_claim.erl
Compiled src/riak_core_stat_cache.erl
Compiled src/riak_core.erl
Compiled src/riak_core_handoff_manager.erl
Compiled src/riak_core_apl.erl
Compiled src/riak_core_vnode.erl
Compiled src/riak_core_capability.erl
Compiled src/riak_core_priority_queue.erl
Compiled src/riak_core_eventhandler_guard.erl
Compiled src/riak_core_base64url.erl

---

✅ MAKE_TEST

Started at: 2017-03-10 12:09
Duration: 597 seconds.
Result: OK
Message: OK
Exit Code: 0

📄

cd /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae; make test




  
  
... Snipped 1263 lines ...
/3 line 131 in context child_terminated
12:17:44.679 [info] Application lager started on node nonode@nohost
  sync_command_test: sync_test_ (Assert sync exit)...ok
12:17:44.679 [error] CRASH REPORT Process <0.25266.0> with 0 neighbours exited with reason: {{already_started,<0.6662.0>},{exometer_core_app,start,[normal,[]]}} in application_master:init/4 line 133
12:17:44.680 [info] Application exometer_core exited with reason: {{already_started,<0.6662.0>},{exometer_core_app,start,[normal,[]]}}
12:17:44.684 [error] mock_vnode command failed core_breach
12:17:44.684 [error] gen_fsm <0.25275.0> in state active terminated with reason: core_breach
12:17:44.684 [error] CRASH REPORT Process <0.25275.0> with 0 neighbours exited with reason: core_breach in gen_fsm:terminate/7 line 622
12:17:44.684 [error] Supervisor riak_core_vnode_sup had child undefined started with {riak_core_vnode,start_link,undefined} at <0.25275.0> exit with reason core_breach in context child_terminated
12:17:44.753 [info] Application lager started on node nonode@nohost
  sync_command_test: sync_test_ (Assert non-blocking sync error)...ok
12:17:44.753 [error] CRASH REPORT Process <0.25311.0> with 0 neighbours exited with reason: {{already_started,<0.6662.0>},{exometer_core_app,start,[normal,[]]}} in application_master:init/4 line 133
12:17:44.754 [info] Application exometer_core exited with reason: {{already_started,<0.6662.0>},{exometer_core_app,start,[normal,[]]}}
12:17:44.758 [error] mock_vnode command failed {core_breach,[{mock_vnode,handle_command,3,[{file,"test/mock_vnode.erl"},{line,131}]},{riak_core_vnode,vnode_command,3,[{file,"src/riak_core_vnode.erl"},{line,346}]},{gen_fsm,handle_msg,7,[{file,"gen_fsm.erl"},{line,505}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,239}]}]}
12:17:44.758 [error] gen_fsm <0.25320.0> in state active terminated with reason: core_breach in mock_vnode:handle_command/3 line 131
12:17:44.758 [error] CRASH REPORT Process <0.25320.0> with 0 neighbours exited with reason: core_breach in mock_vnode:handle_command/3 line 131 in gen_fsm:terminate/7 line 622
12:17:44.758 [error] Supervisor riak_core_vnode_sup had child undefined started with {riak_core_vnode,start_link,undefined} at <0.25320.0> exit with reason core_breach in mock_vnode:handle_command/3 line 131 in context child_terminated
12:17:44.819 [info] Application lager started on node nonode@nohost
  sync_command_test: sync_test_ (Assert non-blocking sync exit)...ok
12:17:44.820 [error] CRASH REPORT Process <0.25357.0> with 0 neighbours exited with reason: {{already_started,<0.6662.0>},{exometer_core_app,start,[normal,[]]}} in application_master:init/4 line 133
12:17:44.820 [info] Application exometer_core exited with reason: {{already_started,<0.6662.0>},{exometer_core_app,start,[normal,[]]}}
12:17:44.824 [error] mock_vnode command failed core_breach
12:17:44.824 [error] gen_fsm <0.25366.0> in state active terminated with reason: core_breach
12:17:44.824 [error] CRASH REPORT Process <0.25366.0> with 0 neighbours exited with reason: core_breach in gen_fsm:terminate/7 line 622
12:17:44.824 [error] Supervisor riak_core_vnode_sup had child undefined started with {riak_core_vnode,start_link,undefined} at <0.25366.0> exit with reason core_breach in context child_terminated
  [done in 0.374 s]
module 'riak_core_ssl_util'
module 'riak_core_handoff_receiver'
module 'riak_core_ring_handler'
module 'test_guarded_event_handler'
  test_guarded_event_handler: guarded_handler_test_...[0.102 s] ok
  [done in 0.105 s]
module 'riak_core_vnode_worker'
module 'riak_core_handoff_manager'
  riak_core_handoff_manager:674: handoff_test_...ok
  riak_core_handoff_manager:675: handoff_test_...ok
  [done in 0.006 s]
module 'riak_core_dtrace'
  riak_core_dtrace: timeit_naive_test...timeit_naive                 average     1.476 usec/call over     500.0 calls
[0.013 s] ok
  riak_core_dtrace: timeit_mochiglobal_test...timeit_mochiglobal           average     2.382 usec/call over  225000.0 calls
[0.549 s] ok
  Skipping timeit_best_on test: no DTrace/SystemTap is available
riak_core_dtrace: timeit_best_off_test...ok
  riak_core_dtrace: timeit_best_onfalse_test...Skipping timeit_best_on test: no DTrace/SystemTap is available
ok
  riak_core_dtrace: timeit_best_ontrue_test...Skipping timeit_best_on test: no DTrace/SystemTap is available
NOTE: cover analysis will skew results.  Run without cover for true timings.
ok
  riak_core_dtrace: last_test...ok
  [done in 0.580 s]
riak_core_format: human_time_fmt_test (module 'riak_core_format')...ok
module 'riak_core_metadata_exchange_fsm'
module 'worker_pool_test'
  worker_pool_test: pool_test_...[1.201 s] ok
  worker_pool_test: pool_test_...[1.201 s] ok
  [done in 2.408 s]
module 'riak_core_vnode_master'
module 'riak_core_cluster_cli'
module 'riak_core_metadata_manager'
module 'claim_simulation'
module 'riak_core_claim'
  riak_core_claim: wants_claim_test...[0.004 s] ok
  riak_core_claim: find_biggest_hole_test...ok
  riak_core_claim: prop_claim_ensures_unique_nodes_v2_test_.......................................................................................................
OK, passed 100 tests
[2.196 s] ok
  riak_core_claim: prop_claim_ensures_unique_nodes_v3_test_........
OK, passed 5 tests
[23.434 s] ok
  riak_core_claim: wants_counts_test.......................................................................................................
OK, passed 100 tests
[0.009 s] ok
  riak_core_claim: wants_test.......................................................................................................
OK, passed 100 tests
[0.115 s] ok
  riak_core_claim: take_idxs_test.......................................................................................................
OK, passed 100 tests
[0.054 s] ok
  [done in 25.833 s]
vclock_qc:21: eqc_test_ (module 'vclock_qc').......................................................................................................(x10)........................................................................(x1).........
Time limit reached: 20.0 seconds.

OK, passed 829 tests

46.21% 0
24.59% 1
12.96% 2
7.52% 3
5.20% 4
3.51% 5

11.245% {vclock_qc,fresh,0}
10.989% {vclock_qc,timestamp,0}
9.800% {vclock_qc,dominates,2}
9.798% {vclock_qc,get_dot,2}
9.747% {vclock_qc,get_timestamp,2}
9.717% {vclock_qc,descends_dot,3}
9.697% {vclock_qc,descends,2}
9.695% {vclock_qc,increment,2}
9.690% {vclock_qc,get_counter,2}
9.622% {vclock_qc,merge,1}

46.8% {num_vclocks_div_10,0}
20.5% {num_vclocks_div_10,1}
11.3% {num_vclocks_div_10,2}
6.5% {num_vclocks_div_10,3}
4.7% {num_vclocks_div_10,4}
2.3% {num_vclocks_div_10,5}
2.1% {num_vclocks_div_10,7}
1.7% {num_vclocks_div_10,6}
0.8% {num_vclocks_div_10,11}
0.8% {num_vclocks_div_10,8}
0.7% {num_vclocks_div_10,10}
0.5% {num_vclocks_div_10,14}
0.5% {num_vclocks_div_10,9}
0.2% {num_vclocks_div_10,15}
0.2% {num_vclocks_div_10,12}
0.1% {num_vclocks_div_10,17}
0.1% {num_vclocks_div_10,16}
[20.024 s] ok
module 'riak_core_send_msg'
riak_core_bucket: simple_set_test (module 'riak_core_bucket')...[0.005 s] ok
module 'riak_core_handoff_sender_sup'
module 'riak_core_coverage_plan'
module 'riak_core_eventhandler_sup'
module 'riak_core_repair'
module 'bucket_eqc_utils'
module 'vclock'
  vclock: example_test...ok
  vclock: prune_small_test...ok
  vclock: prune_young_test...ok
  vclock: prune_big_test...ok
  vclock: prune_old_test...ok
  vclock: prune_order_test...ok
  vclock: accessor_test...ok
  vclock: merge_test...ok
  vclock: merge_less_left_test...ok
  vclock: merge_less_right_test...ok
  vclock: merge_same_id_test...ok
  vclock: get_entry_test...ok
  vclock: valid_entry_test...ok
  [done in 0.039 s]
module 'riak_core_ring_manager'
  riak_core_ring_manager: back_test...ok
  riak_core_ring_manager: prune_list_test...ok
  riak_core_ring_manager: set_ring_global_test...[0.008 s] ok
  riak_core_ring_manager: set_my_ring_test...[0.007 s] ok
  riak_core_ring_manager: refresh_my_ring_test...ok
  riak_core_ring_manager: do_write_ringfile_test...[0.030 s] ok
  riak_core_ring_manager: is_stable_ring_test...ok
  [done in 0.067 s]
module 'riak_core_handoff_sup'
module 'riak_core_capability'
  riak_core_capability_tests: basic_test (module 'riak_core_capability_tests')...[0.001 s] ok
  [done in 0.004 s]
module 'riak_core_handoff_cli'
module 'riak_core_broadcast_handler'
module 'mock_vnode'
module 'bloom'
  bloom: fixed_case_test_...[1.034 s] ok
  bloom: bloom_test...[0.646 s] ok
  [done in 1.686 s]
module 'riak_core_vnode_sup'
module 'process_proxy'
module 'riak_core_dist_mon'
module 'riak_core_bucket_type'
module 'riak_core_gossip'
module 'app_helper'
  app_helper: app_helper_test_...ok
  app_helper: app_helper_test_...ok
  app_helper: app_helper_test_...ok
  app_helper: app_helper_test_...ok
  app_helper: app_helper_test_...ok
  app_helper: app_helper_test_...ok
  [done in 0.018 s]
module 'bg_manager_tests'
  bg_manager_tests: bg_mgr_test_ (set/get token rates + verify rates)...ok
  bg_manager_tests: bg_mgr_test_ (crash token manager + verify rates persist)...[0.303 s] ok
  bg_manager_tests: bg_mgr_test_ (lock/token separation)...ok
  bg_manager_tests: bg_mgr_test_ (failing crash/revive EQC test case)...[0.303 s] ok
  bg_manager_tests: bg_mgr_test_ (bypass API)...ok
  [done in 0.621 s]
module 'riak_core_schema_tests'
  riak_core_schema_tests: basic_schema_test...[0.070 s] ok
  riak_core_schema_tests: invalid_states_test...[0.029 s] ok
  riak_core_schema_tests: default_bucket_properties_test...[0.030 s] ok
  riak_core_schema_tests: override_schema_test...[0.030 s] ok
  [done in 0.171 s]
=======================================================
  All 430 tests passed.
Cover analysis: /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/.eunit/index.html

=INFO REPORT==== 10-Mar-2017::12:19:19 ===
    application: ssl
    exited: stopped
    type: temporary

=INFO REPORT==== 10-Mar-2017::12:19:19 ===
    application: inets
    exited: killed
    type: temporary

---

✅ MAKE_XREF

Started at: 2017-03-10 12:19
Duration: 5 seconds.
Result: OK
Message: OK
Exit Code: 0

📄

cd /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae; make xref




  ./rebar get-deps
==> goldrush (get-deps)
==> lager (get-deps)
==> poolboy (get-deps)
==> basho_stats (get-deps)
==> getopt (get-deps)
==> neotoma (get-deps)
==> cuttlefish (get-deps)
==> riak_sysmon (get-deps)
==> eleveldb (get-deps)
==> riak_ensemble (get-deps)
==> pbkdf2 (get-deps)
==> edown (get-deps)
==> parse_trans (get-deps)
==> bear (get-deps)
==> meck (get-deps)
==> folsom (get-deps)
==> setup (get-deps)
==> src (get-deps)
==> exometer_core (get-deps)
==> clique (get-deps)
==> develop.191c4fa.nem-remove-more-legacy-search.0a021ae (get-deps)
./rebar compile
==> goldrush (compile)
==> lager (compile)
==> poolboy (compile)
==> basho_stats (compile)
==> getopt (compile)
==> neotoma (compile)
==> cuttlefish (compile)
==> getopt (escriptize)
==> goldrush (escriptize)
==> lager (escriptize)
==> neotoma (escriptize)
==> cuttlefish (escriptize)
==> riak_sysmon (compile)
==> eleveldb (compile)
make[1]: Entering directory `/tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/leveldb'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/leveldb'
make[1]: Entering directory `/tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/leveldb'
make[1]: Nothing to be done for `tools'.
make[1]: Leaving directory `/tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/eleveldb/c_src/leveldb'
==> riak_ensemble (compile)
==> pbkdf2 (compile)
==> edown (compile)
==> parse_trans (compile)
==> bear (compile)
==> meck (compile)
==> folsom (compile)
==> setup (compile)
==> edown (escriptize)
==> setup (escriptize)
==> src (compile)
==> exometer_core (compile)
==> clique (compile)
==> develop.191c4fa.nem-remove-more-legacy-search.0a021ae (compile)
./rebar xref skip_deps=true
WARN:  Ignoring sub_dirs for /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae/deps/exometer_core
==> develop.191c4fa.nem-remove-more-legacy-search.0a021ae (xref)

---

✅ MAKE_DIALYZER

Started at: 2017-03-10 12:19
Duration: 41 seconds.
Result: OK
Message: OK
Exit Code: 0

📄

cd /tmp/thumbs/develop.191c4fa.nem-remove-more-legacy-search.0a021ae; make dialyzer




  
  
... Snipped 181 lines ...
1
  erl_syntax:application/2
  erl_syntax:application/3
  erl_syntax:application_arguments/1
  erl_syntax:arity_qualifier/2
  erl_syntax:arity_qualifier_argument/1
  erl_syntax:arity_qualifier_body/1
  erl_syntax:atom/1
  erl_syntax:atom_value/1
  erl_syntax:attribute/2
  erl_syntax:attribute_arguments/1
  erl_syntax:attribute_name/1
  erl_syntax:case_expr/2
  erl_syntax:catch_expr/1
  erl_syntax:clause/2
  erl_syntax:clause/3
  erl_syntax:clause_patterns/1
  erl_syntax:fun_expr_clauses/1
  erl_syntax:function/2
  erl_syntax:function_clauses/1
  erl_syntax:generator/2
  erl_syntax:generator_body/1
  erl_syntax:generator_pattern/1
  erl_syntax:get_pos/1
  erl_syntax:implicit_fun/2
  erl_syntax:implicit_fun_name/1
  erl_syntax:integer/1
  erl_syntax:integer_value/1
  erl_syntax:list/1
  erl_syntax:list_comp/2
  erl_syntax:list_comp_body/1
  erl_syntax:list_comp_template/1
  erl_syntax:list_elements/1
  erl_syntax:match_expr/2
  erl_syntax:revert/1
  erl_syntax:revert_forms/1
  erl_syntax:string/1
  erl_syntax:string_value/1
  erl_syntax:subtrees/1
  erl_syntax:tuple/1
  erl_syntax:tuple_elements/1
  erl_syntax:type/1
  erl_syntax:underscore/0
  erl_syntax:update_tree/2
  erl_syntax:variable/1
  erl_syntax:variable_name/1
  erl_syntax_lib:analyze_application/1
  erl_syntax_lib:analyze_forms/1
  erl_syntax_lib:analyze_function/1
  erl_syntax_lib:map/2
  erl_syntax_lib:variables/1
  erlang:append_element/2
  erlang:atom_to_binary/2
  erlang:atom_to_list/1
  erlang:binary_to_atom/2
  erlang:binary_to_existing_atom/2
  erlang:binary_to_list/1
  erlang:binary_to_list/3
  erlang:binary_to_term/1
  erlang:bitstring_to_list/1
  erlang:bump_reductions/1
  erlang:cancel_timer/1
  erlang:crc32/1
  erlang:demonitor/1
  erlang:demonitor/2
  erlang:erase/1
  erlang:exit/2
  erlang:float_to_list/1
  erlang:float_to_list/2
  erlang:fun_info/2
  erlang:fun_to_list/1
  erlang:function_exported/3
  erlang:garbage_collect/0
  erlang:get/1
  erlang:get_module_info/1
  erlang:get_module_info/2
  erlang:get_stacktrace/0
  erlang:group_leader/0
  erlang:group_leader/2
  erlang:integer_to_list/1
  erlang:iolist_size/1
  erlang:iolist_to_binary/1
  erlang:is_alive/0
  erlang:is_builtin/3
  erlang:is_map/1
  erlang:is_process_alive/1
  erlang:link/1
  erlang:list_to_atom/1
  erlang:list_to_binary/1
  erlang:list_to_existing_atom/1
  erlang:list_to_float/1
  erlang:list_to_integer/1
  erlang:list_to_tuple/1
  erlang:load_nif/2
  erlang:localtime/0
  erlang:make_fun/3
  erlang:make_ref/0
  erlang:map_size/1
  erlang:max/2
  erlang:min/2
  erlang:monitor/2
  erlang:now/0
  erlang:phash2/1
  erlang:phash2/2
  erlang:pid_to_list/1
  erlang:port_info/1
  erlang:port_info/2
  erlang:port_to_list/1
  erlang:ports/0
  erlang:process_flag/2
  erlang:process_info/2
  erlang:processes/0
  erlang:put/2
  erlang:raise/3
  erlang:ref_to_list/1
  erlang:register/2
  erlang:registered/0
  erlang:send/2
  erlang:send/3
  erlang:send_after/3
  erlang:spawn_link/3
  erlang:spawn_monitor/1
  erlang:split_binary/2
  erlang:start_timer/3
  erlang:statistics/1
  erlang:system_monitor/0
  erlang:system_monitor/2
  erlang:term_to_binary/1
  erlang:trace_info/2
  erlang:trace_pattern/3
  erlang:universaltime/0
  erlang:unlink/1
  erlang:whereis/1
  error_logger:add_report_handler/1
  error_logger:delete_report_handler/1
  error_logger:error_msg/1
  error_logger:error_msg/2
  error_logger:format/2
  error_logger:info_msg/2
  error_logger:info_report/1
  error_logger:warning_msg/1
  escript:script_name/0
  ets:all/0
  ets:delete/1
  ets:delete/2
  ets:delete_all_objects/1
  ets:delete_object/2
  ets:first/1
  ets:foldl/3
  ets:give_away/3
  ets:info/1
  ets:info/2
  ets:insert/2
  ets:insert_new/2
  ets:last/1
  ets:lookup/2
  ets:lookup_element/3
  ets:match/2
  ets:match_spec_compile/1
  ets:match_spec_run/2
  ets:member/2
  ets:new/2
  ets:next/2
  ets:prev/2
  ets:select/1
  ets:select/2
  ets:select/3
  ets:select_count/2
  ets:select_delete/2
  ets:select_reverse/3
  ets:setopts/2
  ets:tab2list/1
  ets:update_counter/3
  ets:update_element/3
  eunit:test/1
  file:close/1
  file:consult/1
  file:datasync/1
  file:delete/1
  file:format_error/1
  file:get_cwd/0
  file:list_dir/1
  file:make_dir/1
  file:open/2
  file:read/2
  file:read_file/1
  file:read_file_info/1
  file:rename/2
  file:script/1
  file:script/2
  file:set_cwd/1
  file:sync/1
  file:write/2
  file:write_file/2
  filelib:ensure_dir/1
  filelib:is_dir/1
  filelib:is_file/1
  filelib:is_regular/1
  filelib:wildcard/1
  filelib:wildcard/2
  filename:absname/1
  filename:append/2
  filename:basename/1
  filename:basename/2
  filename:dirname/1
  filename:extension/1
  filename:join/1
  filename:join/2
  filename:split/1
  gb_trees:empty/0
  gb_trees:enter/3
  gb_trees:from_orddict/1
  gb_trees:get/2
  gb_trees:iterator/1
  gb_trees:lookup/2
  gb_trees:next/1
  gb_trees:size/1
  gen_event:add_sup_handler/3
  gen_event:call/3
  gen_event:call/4
  gen_event:delete_handler/3
  gen_event:notify/2
  gen_event:sync_notify/2
  gen_event:which_handlers/1
  gen_fsm:cancel_timer/1
  gen_fsm:reply/2
  gen_fsm:send_all_state_event/2
  gen_fsm:send_event/2
  gen_fsm:send_event_after/2
  gen_fsm:start/3
  gen_fsm:start_link/3
  gen_fsm:sync_send_all_state_event/2
  gen_fsm:sync_send_all_state_event/3
  gen_fsm:sync_send_event/2
  gen_fsm:sync_send_event/3
  gen_server:call/2
  gen_server:call/3
  gen_server:cast/2
  gen_server:reply/2
  gen_server:start/3
  gen_server:start/4
  gen_server:start_link/3
  gen_server:start_link/4
  hamcrest:assert_that/2
  hamcrest:is_matcher/1
  igor:parse_transform/2
  inet:getopts/2
  inet:getstat/1
  inet:parse_address/1
  inet:peername/1
  inet:sockname/1
  init:archive_extension/0
  init:get_argument/1
  init:script_id/0
  init:stop/1
  io:columns/0
  io:format/1
  io:format/2
  io:format/3
  io:fwrite/1
  io:fwrite/2
  io:fwrite/3
  io:put_chars/1
  io:put_chars/2
  io_lib:deep_char_list/1
  io_lib:format/2
  io_lib:fwrite/2
  io_lib:printable_list/1
  io_lib:write/1
  io_lib:write/2
  io_lib:write_atom/1
  io_lib_format:fwrite_g/1
  io_lib_pretty:print/6
  lager_default_tracer:info/1
  lib:format_exception/6
  lists:append/1
  lists:concat/1
  lists:duplicate/2
  lists:flatlength/1
  lists:keystore/4
  lists:keytake/3
  lists:prefix/2
  lists:seq/2
  lists:sublist/2
  lists:sublist/3
  lists:sum/1
  lists:ukeymerge/3
  lists:ukeysort/2
  maps:to_list/1
  math:cos/1
  math:exp/1
  math:log/1
  math:log10/1
  math:pi/0
  math:pow/2
  math:sqrt/1
  memsup:get_system_memory_data/0
  mochijson2:encode/1
  mustache:render/2
  net_adm:ping/1
  orddict:append/3
  orddict:append_list/3
  orddict:erase/2
  orddict:fetch_keys/1
  orddict:find/2
  orddict:fold/3
  orddict:merge/3
  orddict:new/0
  orddict:store/3
  orddict:update/4
  orddict:update_counter/3
  ordsets:add_element/2
  ordsets:del_element/2
  ordsets:from_list/1
  ordsets:intersection/2
  ordsets:is_element/2
  ordsets:new/0
  ordsets:subtract/2
  ordsets:union/2
  os:cmd/1
  os:getenv/1
  os:timestamp/0
  os:type/0
  prim_inet:getstatus/1
  prim_inet:gettype/1
  proc_lib:init_ack/2
  proc_lib:spawn/1
  proc_lib:start_link/3
  proplists:delete/2
  proplists:get_all_values/2
  proplists:get_bool/2
  proplists:get_keys/1
  proplists:get_value/2
  proplists:get_value/3
  proplists:is_defined/2
  proplists:lookup/2
  queue:filter/2
  queue:in/2
  queue:is_empty/1
  queue:len/1
  queue:member/2
  queue:new/0
  queue:out/1
  queue:to_list/1
  random:seed/0
  random:seed/1
  random:seed/3
  random:seed0/0
  random:uniform/0
  random:uniform/1
  random:uniform_s/2
  re:compile/1
  re:compile/2
  re:replace/4
  re:run/2
  re:run/3
  re:split/3
  rebar_config:get_local/3
  rebar_mustache:render/2
  rebar_rel_utils:get_target_dir/2
  rebar_rel_utils:is_rel_dir/0
  rebar_rel_utils:load_config/2
  release_handler:eval_appup_script/4
  rpc:call/4
  rpc:eval_everywhere/3
  rpc:multicall/3
  rpc:multicall/4
  rpc:multicall/5
  sets:add_element/2
  sets:del_element/2
  sets:from_list/1
  sets:is_element/2
  sets:new/0
  sets:size/1
  sets:to_list/1
  string:centre/2
  string:chr/2
  string:cspan/2
  string:join/2
  string:left/2
  string:left/3
  string:rchr/2
  string:right/2
  string:str/2
  string:strip/1
  string:strip/2
  string:sub_string/2
  string:sub_string/3
  string:substr/2
  string:substr/3
  string:to_lower/1
  string:tokens/2
  supervisor:delete_child/2
  supervisor:start_child/2
  supervisor:start_link/2
  supervisor:start_link/3
  supervisor:terminate_child/2
  supervisor:which_children/1
  sys:get_debug/3
  sys:handle_system_msg/6
  systools:make_script/2
  timer:apply_interval/4
  timer:cancel/1
  timer:now_diff/2
  timer:seconds/1
  timer:send_interval/2
  timer:sleep/1
  timer:tc/1
  timer:tc/2
  timer:tc/3
  unicode:characters_to_binary/1
  unicode:characters_to_binary/3
  unicode:characters_to_list/1
  unicode:characters_to_list/2
  xmerl:export_simple/2
  xmerl_html:'#element#'/5
  xmerl_lib:end_tag/1
  xmerl_lib:expand_element/1
  xmerl_lib:find_attribute/2
  xmerl_lib:mapxml/2
  xmerl_lib:start_tag/2
Unknown types:
  calendar:datetime/0
  erl_syntax:syntaxTree/0
  erlang:timestamp/0
  ets:comp_match_spec/0
  ets:match_spec/0
  ets:tab/0
  ets:tid/0
  file:date_time/0
  file:fd/0
  file:filename/0
  file:io_device/0
  file:name/0
  file:name_all/0
  file:posix/0
  hamcrest:matchspec/0
  meck_history:history_record/0
  orddict:orddict/0
  proplists:property/0
  proplists:proplist/0
  re:mp/0
  supervisor:child_spec/0
  timer:tref/0
  unicode:charlist/0
 done in 0m5.71s
done (passed successfully)
==> develop.191c4fa.nem-remove-more-legacy-search.0a021ae (dialyzer)
  Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes
  Checking whether the PLT .local_dialyzer_plt is up-to-date... yes
  Compiling some key modules to native code... done in 0m8.71s
  Proceeding with analysis...
Unknown functions:
  cluster_info:format/3
  cluster_info:register_app/1
 done in 0m5.60s
done (passed successfully)

---

⬜ 0 of 2 Code reviews from organization basho

[bsparrow435]

+1