Make riak_core_util:safe_rpc catch exit correctly #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change 'EXIT':{noproc, ...} to exit:{noproc, ...}
|
Thanks for catching this, I've assigned the 2.0-RC milestone to both of these issues. |
|
cc @lordnull |
|
👍 as the riak_test proves it's correctness. Of course, bors isn't happy due to a spurious eunit failure (sha_test timeout). |
|
@borshop merge |
|
👍 b01f400 |
borshop
added a commit
that referenced
this pull request
May 30, 2014
Make riak_core_util:safe_rpc catch exit correctly Reviewed-by: lordnull
|
@borshop merge |
borshop
added a commit
that referenced
this pull request
May 31, 2014
Make riak_core_util:safe_rpc catch exit correctly Reviewed-by: lordnull
|
The failure we're seeing here is #590. |
|
Can we manually merge, @reiddraper? |
|
Sure, and I appreciate that we talked about it in the comments. I just want there to at least be an explanation in the comments every time we decide to manually merge. In this case, the explanation is that another test is blocking us, and we'd like to get a better handle on the outstanding issues, so having this closed will help us gain better visibility into what's remaining. |
reiddraper
added a commit
that referenced
this pull request
Jun 3, 2014
Make riak_core_util:safe_rpc catch exit correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was attempting to catch exit exception with 'EXIT':{noproc, ...}; should be exit:{noproc, ...}
http://erlang.org/doc/reference_manual/errors.html
Related riak_test PR:
basho/riak_test#624