Treat users and groups as distinct concepts (extended) #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 19, 2014
| UserGrants = riak_core_metadata:get({<<"security">>, <<"grants">>}, {User, | ||
| Bucket}), | ||
| add_revoke_int([{Name, RoleType}|Roles], Bucket, Permissions) -> | ||
| Prefix = {<<"security">>, list_to_binary(atom_to_list(RoleType) ++ "grants")}, |
There was a problem hiding this comment.
Maybe a pattern matching function for converting the roletype atom to a binary here, instead of this?
|
Can you squash and rebase this off of develop, please? |
…uster metadata storage.
|
+1 to merge. |
macintux
added a commit
that referenced
this pull request
Feb 20, 2014
Treat users and groups as distinct concepts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This consolidates #529 and #533.)
To make it easier to reason about and document the new security behavior, this PR splits roles into users and groups.
Where the code does not or cannot distinguish between users and groups, I continue to refer to roles, but the user interface is constrained to users and groups.
There are 3 projects impacted by this change:
jrd-security-role-bifurcation) Treat users and groups as distinct concepts riak#489jrd-security-grant-namespace)jrd-security-role-bifurcation) Treat users and groups as distinct concepts riak_test#538All should be merged at the same time.
/cc @Vagabond