Removed table manager. #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The background manager tables are now created in the start/1 and start_link/1 tables as public. This puts the owner as the supervisor. If the supervisor dies, the system needs a clean restart anyway. Minimal changes to the tests were needed.
|
Code looks good. All riak_core tests pass before and after merged. Manually ran the eqc test for a while with no errors. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background manager tables are now created in the start/1 and
start_link/1 tables as public. This puts the owner as the supervisor.
If the supervisor dies, the system needs a clean restart anyway.
Minimal changes to the tests were needed.
This supersedes #530 .