Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework table formatting to be better and output better info #435

Merged
merged 1 commit into from
Oct 23, 2013

Conversation

Vagabond
Copy link
Contributor

Basicially tables now auto-size much better and handle multiline fields
much better, without breaking the table. The original table.erl was
something Andrew Stone had lying around, so it wasn't particularly
polished.

cc @jaredmorrow hoping he can review it before Wednesday ;)

Basicially tables now auto-size much better and handle multiline fields
much better, without breaking the table. The original table.erl was
something Andrew Stone had lying around, so it wasn't particularly
polished.
@Vagabond
Copy link
Contributor Author

Oh, ccing @andrewjstone is probably a good idea, too.

@Vagabond
Copy link
Contributor Author

It can now print tables like:

+----------+----------+----------------------------------------+
|   type   |  bucket  |                 grants                 |
+----------+----------+----------------------------------------+
|    *     |    *     |           riak_kv.mapreduce            |
| default  | mybucket |      riak_kv.get, riak_kv.delete,      |
|          |          |              riak_kv.put               |
+----------+----------+----------------------------------------+

where even though the permission list stretches to the next line (word wrapped before being fed into the table), the table formatter pads the other fields to include blank cells to compensate.

@jaredmorrow
Copy link
Contributor

I'll take a look.

@jaredmorrow
Copy link
Contributor

Table formatting looks better, +1

Vagabond added a commit that referenced this pull request Oct 23, 2013
Rework table formatting to be better and output better info
@Vagabond Vagabond merged commit 53a1bb8 into develop Oct 23, 2013
@Vagabond Vagabond deleted the adt-table-formatting branch October 23, 2013 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants