share segment store accross all nodes in hashtree_tree #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
this ensures that we don't create an unbounded number of segment stores (leveldb databases), instead only creating one.
|
rebased and force-pushed on most recent |
|
👍 looks good, merge away! |
jrwest
added a commit
that referenced
this pull request
Nov 12, 2013
share segment store accross all nodes in hashtree_tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ensures that we don't create an unbounded number of segment
stores (leveldb databases), instead only creating one.
addresses #428
exports
hashtree:new/3so that each level can still pass different size options