Sort AAE differences before acting upon them via read-repair #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply patch to hashtree.erl that was developed for basho/riak_kv#646.
|
The patch removed hashtree:compare/3 in favor of hashtree:compare/4 (yay!), but did not modify the code using hashtree:compare/3. I've pushed that in 1240324. The change looks good, eunit tests pass as before (I saw an anomaly in core_vnode_eqc that I had seen this morning in develop). I've tested this with basho/riak_kv#646 and aae repairs are indeed happening in sort order 👍 💃 ⛵ I'm going to merge this myself so it makes it into pre3 |
engelsanchez
added a commit
that referenced
this pull request
Oct 5, 2013
Sort AAE differences before acting upon them via read-repair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply patch to hashtree.erl that was developed for
basho/riak_kv#646.