Fixes #189 -- include socket peer info in lager messages #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Given all the talk about less erlangy log messages lately, I was wondering if it would be OK to display the peername as ip:port instead of directly printing the {IP, Port} tuple. Or maybe [ip]:port to be more IPV6 friendly. Although I'm not sure how IPV6 addresses are represented here. |
|
@engelsanchez Agree, |
|
Nice, that's perfect. Thanks @seancribbs |
|
Looks good. A bit of manual shows it working and showing the remote host and port on the receiving part. Caveat: I did not try it with SSL. 👍 and merging now so it makes it into pre3 |
engelsanchez
added a commit
that referenced
this pull request
Oct 4, 2013
Fixes #189 -- include socket peer info in lager messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject says it all ... the handoff protocol doesn't include the node name of the source node, so the best we can do without a protocol change (and capability negotiation and ...) is to log the socket's peername() info.