Fix for Issue 179 #180
Merged
Fix for Issue 179 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,10 +25,12 @@ end}. | |||
| %% @doc If riak control's authentication mode (riak_control.auth.mode) | |||
| %% is set to 'userlist' then this is the list of usernames and | |||
| %% passwords for access to the admin panel. | |||
| %% To create users with given names, add entries of the format: | |||
| %% riak_control.auth.user.«user name».password = «password» | |||
There was a problem hiding this comment.
I'd prefer not to use guillemot in the schema. We're currently having utf8 vs. latin1 issues anyway, surely those characters are > 127 in latin1 (if they even exist in it).
|
Eng +1 |
|
CSE +1 |
|
Prod +1 |
|
👍, however please open a PR for resulting test failure which will occur here: https://github.com/basho/riak_test/blob/master/tests/riak_control_authentication.erl |
|
@cmeiklejohn I don't see how that will fail, the configs in that test are unchanged. |
|
Ah, yes. You are right. Merge away. |
|
Added to 2.0-RC milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is designed to address issue #179 by changing the default username from "user" to "admin" and creating some additional documentation to explain how to add additional users.